soundwire: Remove redundant zeroing of page registers
Status from this message: Applied, thanks
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest2 patches 1 replyApplied
- v12 patches 3 repliesSuperseded
Changes in v2 from the cover letter
- Reworded the commit message to patch #1:
- say that this is for devices that support paging
- mention bit 15 as the paging flag
- split a long sentence into two sentences.
Patches in v2 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | soundwire: bus: Don't zero page registers after every transactiondrivers/ | +0 | 0 replies | |
| 2/2 | soundwire: bus: Remove unused reset_page_addr() callbackdrivers/ drivers/ drivers/ +1 more | +0 | 0 replies |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Pierre-Louis Bossart |
|---|---|
| 1/2 | R-b |
| 2/2 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/2] soundwire: Remove redundant zeroing of page registers
Writing zero to the page registers after each message transaction can add up to a lot of overhead for codecs that need to transfer large amount of data - for example a firmware download.
There's no spec reason I can see for this zeroing. The page registers are only used for a paged address. The bus code uses a non-paged address for registers in page 0. It always writes the page registers at the start of a paged transaction.
If this zeroing was a workaround for anything, let me know and I will re-implement the zeroing as a quirk that can be enabled only when it is necessary.
Changes since v1:
- Reworded the commit message to patch #1:
- say that this is for devices that support paging
- mention bit 15 as the paging flag
- split a long sentence into two sentences.
No code changes.
Richard Fitzgerald (2):
soundwire: bus: Don't zero page registers after every transaction
soundwire: bus: Remove unused reset_page_addr() callback
drivers/soundwire/bus.c | 23 ----------------------- drivers/soundwire/cadence_master.c | 14 -------------- drivers/soundwire/cadence_master.h | 3 --- drivers/soundwire/intel_auxdevice.c | 1 - include/linux/soundwire/sdw.h | 3 --- 5 files changed, 44 deletions(-)
Signature · 1 line
2.30.2