Skip to content

ASoC: Intel: avs: Data probing and fw logging

Cezary Rojewski alsa-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest16 patches 1 replyIn review
  2. v116 patches 3 repliesSuperseded

Changes in v2 from the cover letter

- reordered sign offs in patch 03 as reported by Takashi
- fixed issue reported by ikp - unintilialized 'runtime' variable in patch 03
- added missing module_get_upon_open in component driver declaration

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16ALSA: hda: Allow for compress stream to hdac_ext_stream assignmentinclude/sound/hdaudio_ext.h sound/hda/ext/hdac_ext_stream.c+43 -00 replies
2/16ALSA: hda: Prepare for compress stream supportsound/hda/hdac_stream.c+16 -160 replies
3/16ALSA: hda: Interrupt servicing and BDL setup for compress streamssound/hda/hdac_controller.c sound/hda/hdac_stream.c+22 -90 replies
4/16ASoC: Intel: avs: Introduce avs_log_buffer_status_locked()sound/soc/intel/avs/apl.c sound/soc/intel/avs/avs.h sound/soc/intel/avs/ipc.c +1 more+15 -110 replies
5/16ASoC: Intel: avs: Drop fifo_locksound/soc/intel/avs/apl.c sound/soc/intel/avs/avs.h sound/soc/intel/avs/skl.c +1 more+7 -140 replies
6/16ASoC: Intel: avs: Introduce debug-context aware helperssound/soc/intel/avs/Makefile sound/soc/intel/avs/avs.h sound/soc/intel/avs/debugfs.c+61 -00 replies
7/16ASoC: Intel: avs: Make enable_logs() dependent on DEBUG_FSsound/soc/intel/avs/apl.c sound/soc/intel/avs/avs.h sound/soc/intel/avs/messages.c +1 more+32 -230 replies
8/16ASoC: Intel: avs: Drop usage of debug members in non-debug codesound/soc/intel/avs/apl.c sound/soc/intel/avs/avs.h sound/soc/intel/avs/debugfs.c +2 more+26 -420 replies
9/16ASoC: Intel: avs: Add data probing requestssound/soc/intel/avs/Makefile sound/soc/intel/avs/messages.c sound/soc/intel/avs/messages.h +1 more+178 -10 replies
10/16ASoC: Intel: avs: Probe compress operationssound/soc/intel/Kconfig sound/soc/intel/avs/avs.h sound/soc/intel/avs/probes.c+225 -30 replies
11/16ASoC: Intel: avs: Data probing soc-componentsound/soc/intel/avs/avs.h sound/soc/intel/avs/pcm.c sound/soc/intel/avs/probes.c+64 -50 replies
12/16ASoC: Intel: avs: Add probe machine boardsound/soc/intel/avs/board_selection.c sound/soc/intel/avs/boards/Kconfig sound/soc/intel/avs/boards/Makefile +1 more+107 -00 replies
13/16ASoC: Intel: avs: Probing and firmware tracing over debugfssound/soc/intel/avs/avs.h sound/soc/intel/avs/core.c sound/soc/intel/avs/debugfs.c+335 -00 replies
14/16ASoC: Intel: avs: Gather remaining logs on strace_release()sound/soc/intel/avs/debugfs.c+15 -10 replies
15/16ASoC: Intel: avs: Allow for dumping FW_REGS areasound/soc/intel/avs/debugfs.c+24 -00 replies
16/16ASoC: Intel: avs: Allow for dumping debug window snapshotsound/soc/intel/avs/debugfs.c sound/soc/intel/avs/registers.h+28 -10 replies

Reviews trailers per patch

3 of 16 patches have a Reviewed-by or Acked-by.

PatchTakashi Iwai
1/16A-b
2/16A-b
3/16A-b
4/16
5/16
6/16
7/16
8/16
9/16
10/16
11/16
12/16
13/16
14/16
15/16
16/16

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/16] ASoC: Intel: avs: Data probing and fw logging

The patchset focuses on debug functionality for the avs-driver. Two major blocks are covered here: data probing and AudioDSP firmware logging. Both are configured and controlled through debugfs.

Data probing is a AudioDSP debug functionality which allows for gathering the actual data that is being routed to or from a module. Helps in debugging its processing capabilities - navigate to a specific module which may have caused a glitch within a pipeline (set of modules bound together).

First few allow for assigning compress stream to a HDAudio stream, what is currently limited to pcm substreams only. These patches were already present on this list and reviewed in the past [1].

The next few tidy existing debug-related code up so it's ready for addition of new functionalities and make it clear which part of the avs is debug related and which is not. These also simplify the existing locking around the trace fifo.

Afterward, debug-related IPCs are defined along with stub soc-component and compress DAI operations. Not much is done there as it's not a standard PCM streaming scenario. Most code found in compress operations is inherited from the HOST side of HDAudio streaming found in pcm.c file of the driver.

Finally, a debugfs file operations are defined. These facilitate connecting to DSP modules from which the data shall be gathered as well as control and configuration of firmware logging. Additionally, entries are added to allow for dumping snapshots of key memory windows.

Changes in v2:
- reordered sign offs in patch 03 as reported by Takashi
- fixed issue reported by ikp - unintilialized 'runtime' variable in patch 03
- added missing module_get_upon_open in component driver declaration

[1]: https://lore.kernel.org/alsa-devel/[email protected]/

Cezary Rojewski (16):
ALSA: hda: Allow for compress stream to hdac_ext_stream assignment
ALSA: hda: Prepare for compress stream support
ALSA: hda: Interrupt servicing and BDL setup for compress streams
ASoC: Intel: avs: Introduce avs_log_buffer_status_locked()
ASoC: Intel: avs: Drop fifo_lock
ASoC: Intel: avs: Introduce debug-context aware helpers
ASoC: Intel: avs: Make enable_logs() dependent on DEBUG_FS
ASoC: Intel: avs: Drop usage of debug members in non-debug code
ASoC: Intel: avs: Add data probing requests
ASoC: Intel: avs: Probe compress operations
ASoC: Intel: avs: Data probing soc-component
ASoC: Intel: avs: Add probe machine board
ASoC: Intel: avs: Probing and firmware tracing over debugfs
ASoC: Intel: avs: Gather remaining logs on strace_release()
ASoC: Intel: avs: Allow for dumping FW_REGS area
ASoC: Intel: avs: Allow for dumping debug window snapshot

 include/sound/hdaudio_ext.h           |   2 +
 sound/hda/ext/hdac_ext_stream.c       |  41 +++
 sound/hda/hdac_controller.c           |   4 +-
 sound/hda/hdac_stream.c               |  51 +--
 sound/soc/intel/Kconfig               |   1 +
 sound/soc/intel/avs/Makefile          |   4 +
 sound/soc/intel/avs/apl.c             |  24 +-
 sound/soc/intel/avs/avs.h             |  80 ++++-
 sound/soc/intel/avs/board_selection.c |  33 ++
 sound/soc/intel/avs/boards/Kconfig    |   8 +
 sound/soc/intel/avs/boards/Makefile   |   2 +
 sound/soc/intel/avs/boards/probe.c    |  64 ++++
 sound/soc/intel/avs/core.c            |   2 +
 sound/soc/intel/avs/debugfs.c         | 436 ++++++++++++++++++++++++++
 sound/soc/intel/avs/ipc.c             |   2 +-
 sound/soc/intel/avs/messages.c        | 104 +++++-
 sound/soc/intel/avs/messages.h        |  53 ++++
 sound/soc/intel/avs/pcm.c             |   6 +-
 sound/soc/intel/avs/probes.c          | 313 ++++++++++++++++++
 sound/soc/intel/avs/registers.h       |   3 +-
 sound/soc/intel/avs/skl.c             |  17 +-
 sound/soc/intel/avs/utils.c           |  22 --
 22 files changed, 1172 insertions(+), 100 deletions(-)
 create mode 100644 sound/soc/intel/avs/boards/probe.c
 create mode 100644 sound/soc/intel/avs/debugfs.c
 create mode 100644 sound/soc/intel/avs/probes.c
Signature · 1 line
2.25.1