Skip to content

wifi: rtw89: adjust early loading firmware for SECURITY_LOADPIN_ENFORCE

Ping-Ke Shih linux-wireless 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2wifi: rtw89: don't request partial firmware if SECURITY_LOADPIN_ENFORCEdrivers/net/wireless/realtek/rtw89/fw.c drivers/net/wireless/realtek/rtw89/fw.h+36 -91 reply
2/2wifi: rtw89: request full firmware only once if it's early requesteddrivers/net/wireless/realtek/rtw89/core.c drivers/net/wireless/realtek/rtw89/fw.c drivers/net/wireless/realtek/rtw89/fw.h+32 -90 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] wifi: rtw89: adjust early loading firmware for SECURITY_LOADPIN_ENFORCE

Originally, we early load partial firmware to know its capability before register_hw(), because it can save some loading time. However, a platform can enable SECURITY_LOADPIN_ENFORCE that disallows to load firmware partially, so we load full firmware instead in this kind of platform. The costs of loading partial and full firmware are about 10us and 100us in 10+ years old computer, so I think this isn't very critical for users.

We are still thinking if we can fork a work during PCI probe to load firmware and register_hw(), but this will be a big change of initial flow. Before the implement, this patchset can let driver works as expectation and avoid kernel warning if SECURITY_LOADPIN_ENFORCE is enabled.

Zong-Zhe Yang (2):
wifi: rtw89: don't request partial firmware if
SECURITY_LOADPIN_ENFORCE
wifi: rtw89: request full firmware only once if it's early requested

 drivers/net/wireless/realtek/rtw89/core.c |  6 ++-
 drivers/net/wireless/realtek/rtw89/fw.c   | 60 +++++++++++++++++------
 drivers/net/wireless/realtek/rtw89/fw.h   | 22 +++++++--
 3 files changed, 69 insertions(+), 19 deletions(-)
Signature · 1 line
2.25.1