Skip to content

Ensure sensor drivers set V4L2_CTRL_FLAG_MODIFY_LAYOUT for flips

Dave Stevenson linux-media 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 4 repliesIn review
  2. v15 patches 1 replySuperseded

Changes in v2 from the cover letter

- Corrected typo in imx355
- Moved setting the flags for ov2680 at Rui's request.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5media: i2c: ov2680: Set V4L2_CTRL_FLAG_MODIFY_LAYOUT on flipsdrivers/media/i2c/ov2680.c+2 -00 replies
2/5media: i2c: imx208: Set V4L2_CTRL_FLAG_MODIFY_LAYOUT on flipsdrivers/media/i2c/imx208.c+4 -00 replies
3/5media: i2c: imx319: Set V4L2_CTRL_FLAG_MODIFY_LAYOUT on flipsdrivers/media/i2c/imx319.c+4 -03 replies
4/5media: i2c: imx355: Set V4L2_CTRL_FLAG_MODIFY_LAYOUT on flipsdrivers/media/i2c/imx355.c+4 -01 reply
5/5media: i2c: ov08d10: Set V4L2_CTRL_FLAG_MODIFY_LAYOUT on flipsdrivers/media/i2c/ov08d10.c+5 -00 replies

Reviews trailers per patch

3 of 5 patches have a Reviewed-by or Acked-by.

PatchRui Miguel SilvaBingbu Cao
1/5A-b
2/5
3/5R-b
4/5R-b
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH V2 0/5] Ensure sensor drivers set V4L2_CTRL_FLAG_MODIFY_LAYOUT for flips

Hi.

I was doing a basic sweep of drivers and noted that these 5 drivers change the Bayer order based on HFLIP and VFLIP. However they don't set the V4L2_CTRL_FLAG_MODIFY_LAYOUT flag on the controls, so userspace has no notion that it needs to check for a changed format.

Add the flag to all the controls.

Dave

Changes from v1:
- Corrected typo in imx355
- Moved setting the flags for ov2680 at Rui's request.

 drivers/media/i2c/imx208.c  | 4 ++++
 drivers/media/i2c/imx319.c  | 4 ++++
 drivers/media/i2c/imx355.c  | 4 ++++
 drivers/media/i2c/ov08d10.c | 5 +++++
 drivers/media/i2c/ov2680.c  | 2 ++
 5 files changed, 19 insertions(+)
Signature · 1 line
2.34.1