Skip to content

dsa: lan9303: Move to PHYLINK

Jerry Ray lkml netdev 7 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (master)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest7 patches 0 repliesApplied 7/7
  2. v66 patches 14 repliesSuperseded
  3. v56 patches 5 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v42 patches6 repliesSuperseded
v32 patches10 repliesSuperseded
v22 patches2 repliesSuperseded
v12 patches0 repliesSuperseded

Changes in v7 from the cover letter

- Moved the initialization of the Turbo bit into lan9303_setup().
- Added a macro for determining is a port is an XMII port.
- Added setting the XMII flow control in the phylink_mac_link_up() API.
- removed unnecessary error handling and cleaned up the code flow in

Patches in v7 All 7 applied

#Subject and filesSizeRepliesApplied
1/7dsa: lan9303: align dsa_switch_ops membersdrivers/net/dsa/lan9303-core.c+19 -190 repliesApplied
2/7dsa: lan9303: move Turbo Mode bit initdrivers/net/dsa/lan9303-core.c+7 -90 repliesApplied
3/7dsa: lan9303: Add exception logic for read failuredrivers/net/dsa/lan9303-core.c+3 -10 repliesApplied
4/7dsa: lan9303: write reg only if necessarydrivers/net/dsa/lan9303-core.c+5 -20 repliesApplied
5/7dsa: lan9303: Port 0 is xMII portdrivers/net/dsa/lan9303-core.c+8 -10 repliesApplied
6/7dsa: lan9303: Migrate to PHYLINKdrivers/net/dsa/lan9303-core.c+69 -320 repliesApplied
7/7dsa: lan9303: Add flow ctrl in link_updrivers/net/dsa/lan9303-core.c+23 -110 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v7 yet.

Read the v7 thread

Cover letter [net-next: PATCH v7 0/7] dsa: lan9303: Move to PHYLINK

This patch series moves the lan9303 driver to use the phylink api away from phylib.

Migrating to phylink means removing the .adjust_link api. The functionality from the adjust_link is moved to the phylink_mac_link_up api. The code being removed only affected the cpu port. The other ports on the LAN9303 do not need anything from the phylink_mac_link_up api.

Patches:
0001 - Whitespace only change aligning the dsa_switch_ops members.
No code changes.
0002 - Moves the Turbo bit initialization out of the adjust_link api and
places it in a driver initialization execution path. It only needs to be initialized once, it is never changed, and it is not a per-port flag.
0003 - Adds exception handling logic in the extremely unlikely event that
the read of the device fails.
0004 - Performance optimization that skips a slow register write if there
is no need to perform it.
0005 - Change the way we identify the xMII port as phydev will be NULL
when this logic is moved into phylink_mac_link_up.
0006 - Removes adjust_link and begins using the phylink dsa_switch_ops
apis.
0007 - Adds XMII port flow control settings in the phylink_mac_link_up()
api while cleaning up the ANEG / speed / duplex implementation.
---
v6->v7:
- Moved the initialization of the Turbo bit into lan9303_setup().
- Added a macro for determining is a port is an XMII port.
- Added setting the XMII flow control in the phylink_mac_link_up() API.
- removed unnecessary error handling and cleaned up the code flow in

    phylink_mac_link_up().

v5->v6:
- Moved to using port number to identify xMII port for the LAN9303.
v4->v5:
- Created prep patches to better show how things migrate.
- cleaned up comments.
v3->v4:
- Addressed whitespace issues as a separate patch.
- Removed port_max_mtu api patch as it is unrelated to phylink migration.
- Reworked the implementation to preserve the adjust_link functionality by including it in the phylink_mac_link_up api.
v2->v3:
Added back in disabling Turbo Mode on the CPU MII interface. Removed the unnecessary clearing of the phy supported interfaces.
v1->v2:
corrected the reported mtu size, removing ETH_HLEN and ETH_FCS_LEN

drivers/net/dsa/lan9303-core.c | xx ++++++++++++--------

 1 file changed