ptp: Introduce .getfine callback to ptp_clock_info
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 2 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | ptp: Add .getfine function to support reporting frequency offset from hardwaredrivers/ include/ | +23 | 0 replies | |
| 2/2 | net/mlx5: Implement ptp_clock_info .getfine functiondrivers/ | +35 | 0 replies |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Gal Pressman | Saeed Mahameed |
|---|---|---|
| 1/2 | R-b | |
| 2/2 | R-b | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH net-next 0/2] ptp: Introduce .getfine callback to ptp_clock_info
The current state of the ptp driver provides the ability to query the frequency of the ptp clock device by caching the frequency values used in previous adjustments done through the ptp driver. This works great when the ptp driver is the only means for changing the clock frequency. However, some devices support ways to adjust the frequency outside the ptp driver stack. When this occurs, the ptp cached value is inaccurate. Also, if the device for some reason does not start with a frequency of zero, the initial frequency queried before the first frequency adjustment would be inaccurate.
The changes proposed enable a callback that various drivers can implement to provide the frequency, in units of scaled ppm, of the ptp clock. When the callback is implemented, it will be called to provide the frequency value instead of the cached dialed_frequency value.
There are cases in linuxptp usage where the caching of the frequency has proven to be inadequate. One example was the case where concurrent ptp4l processes adjust frequency, but the cached frequency values in the ptp4l processes are stale. Permitting implementers the ability to provide the frequency would resolve issues involving stale frequency values due to changes occurring outside the ptp driver stack.
https://sourceforge.net/p/linuxptp/mailman/message/37720193/
Rahul Rameshbabu (2):
ptp: Add .getfine function to support reporting frequency offset from
hardware
net/mlx5: Implement ptp_clock_info .getfine function
.../ethernet/mellanox/mlx5/core/lib/clock.c | 35 +++++++++++++++++++ drivers/ptp/ptp_clock.c | 18 +++++++++- include/linux/ptp_clock_kernel.h | 6 ++++ 3 files changed, 58 insertions(+), 1 deletion(-)
Signature · 1 line
2.36.2