platform/surface: aggregator: Improve target/source handling in SSH messages
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest9 patches 9 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | platform/surface: aggregator: Ignore command messages not intended for usdrivers/ | +14 | 1 reply | |
| 2/9 | platform/surface: aggregator: Improve documentation and handling of message target and source IDsDocumentation/ Documentation/ drivers/ +4 more | +64 | 0 replies | |
| 3/9 | platform/surface: aggregator: Add target and source IDs to command trace eventsdrivers/ | +67 | 0 replies | |
| 4/9 | platform/surface: aggregator_hub: Use target-ID enum instead of hard-coding valuesdrivers/ | +2 | 0 replies | |
| 5/9 | platform/surface: aggregator_tabletsw: Use target-ID enum instead of hard-coding valuesdrivers/ | +3 | 0 replies | |
| 6/9 | platform/surface: dtx: Use target-ID enum instead of hard-coding valuesdrivers/ | +9 | 0 replies | |
| 7/9 | HID: surface-hid: Use target-ID enum instead of hard-coding valuesdrivers/ | +1 | 0 replies | |
| 8/9 | platform/surface: aggregator: Enforce use of target-ID enum in device ID macrosdrivers/ drivers/ drivers/ +5 more | +35 | 1 reply | |
| 9/9 | platform/surface: aggregator_registry: Fix target-ID of base-hubdrivers/ drivers/ | +2 | 0 replies |
Reviews trailers per patch
1 of 9 patches has a Reviewed-by or Acked-by.
| Patch | Sebastian Reichel |
|---|---|
| 1/9 | |
| 2/9 | |
| 3/9 | |
| 4/9 | |
| 5/9 | |
| 6/9 | |
| 7/9 | |
| 8/9 | A-b |
| 9/9 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/9] platform/surface: aggregator: Improve target/source handling in SSH messages
We have some new insights into the Serial Hub protocol, obtained through reverse engineering. In particular, regarding the command structure. The input/output target IDs actually represent source and target IDs of (what looks like) physical entities (specifically: host, SAM EC, KIP EC, debug connector, and SurfLink connector).
This series aims to improve handling of messages with regards to those new findings and, mainly, improve clarity of the documentation and usage around those fields.
See the discussion in
https://github.com/linux-surface/surface-aggregator-module/issues/64
for more details.
There are a couple of standouts:
- Patch 1 ensures that we only handle commands actually intended for us. It's possible that we receive messages not intended for us when we enable debugging. I've kept it intentionally minimal to simplify backporting. The rest of the series patch 9 focuses more on clarity and documentation, which is probably too much to backport.
- Patch 8 touches on multiple subsystems. The intention is to enforce proper usage and documentation of target IDs in the SSAM_SDEV() / SSAM_VDEV() macros. As it directly touches those macros I unfortunately can't split it up by subsystem.
- Patch 9 is a loosely connected cleanup for consistency.
Hans, Jiri, Benjamin, Sebastian: While patch 8 ("platform/surface:
aggregator: Enforce use of target-ID enum in device ID macros") touches multiple subsystems, it should be possible to take the whole series through the pdx86 tree. The changes in other subsystems are fairly limited.
Maximilian Luz (9):
platform/surface: aggregator: Ignore command messages not intended for
us
platform/surface: aggregator: Improve documentation and handling of
message target and source IDs
platform/surface: aggregator: Add target and source IDs to command
trace events
platform/surface: aggregator_hub: Use target-ID enum instead of
hard-coding values
platform/surface: aggregator_tabletsw: Use target-ID enum instead of
hard-coding values
platform/surface: dtx: Use target-ID enum instead of hard-coding
values
HID: surface-hid: Use target-ID enum instead of hard-coding values platform/surface: aggregator: Enforce use of target-ID enum in device
ID macros
platform/surface: aggregator_registry: Fix target-ID of base-hub
.../driver-api/surface_aggregator/client.rst | 4 +- .../driver-api/surface_aggregator/ssh.rst | 36 ++++----- drivers/hid/surface-hid/surface_hid.c | 2 +- drivers/hid/surface-hid/surface_kbd.c | 2 +- .../platform/surface/aggregator/controller.c | 12 +-- .../platform/surface/aggregator/ssh_msgb.h | 4 +- .../surface/aggregator/ssh_request_layer.c | 15 ++++ drivers/platform/surface/aggregator/trace.h | 73 +++++++++++++++++-- .../platform/surface/surface_aggregator_hub.c | 8 +- .../surface/surface_aggregator_registry.c | 2 +- .../surface/surface_aggregator_tabletsw.c | 10 +-- drivers/platform/surface/surface_dtx.c | 20 ++--- .../surface/surface_platform_profile.c | 2 +- drivers/power/supply/surface_battery.c | 4 +- drivers/power/supply/surface_charger.c | 2 +- include/linux/surface_aggregator/controller.h | 4 +- include/linux/surface_aggregator/device.h | 50 ++++++------- include/linux/surface_aggregator/serial_hub.h | 40 ++++++---- 18 files changed, 191 insertions(+), 99 deletions(-)
Signature · 1 line
2.38.1