bridge: mcast: Preparations for EVPN extensions
Status from this message: This series was applied to netdev/net-next.git (master)
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest9 patches 2 repliesApplied 9/9
- v18 patches 11 repliesSuperseded
Changes in v2 from the cover letter
* Patch #1: Remove 'skb' argument from br_mdb_config_init().
* Patch #1: Mark 'nlh' argument as 'const'.
* Patch #4: Pass 'cfg' as 'const'.
* Patch #5: Pass 'cfg' as 'const'.
* Patch #9: New patch.
[1] https://lore.kernel.org/netdev/[email protected]/
[2] https://github.com/idosch/linux/commits/submit/mdb_v1
Patches in v2 All 9 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | bridge: mcast: Centralize netlink attribute parsingnet/ net/ | +127 | 1 reply | Applied |
| 2/9 | bridge: mcast: Remove redundant checksnet/ | +9 | 0 replies | Applied |
| 3/9 | bridge: mcast: Use MDB configuration structure where possiblenet/ | +15 | 0 replies | Applied |
| 4/9 | bridge: mcast: Propagate MDB configuration structure furthernet/ | +11 | 0 replies | Applied |
| 5/9 | bridge: mcast: Use MDB group key from configuration structurenet/ | +7 | 0 replies | Applied |
| 6/9 | bridge: mcast: Remove br_mdb_parse()net/ | +5 | 0 replies | Applied |
| 7/9 | bridge: mcast: Move checks out of critical sectionnet/ | +18 | 0 replies | Applied |
| 8/9 | bridge: mcast: Remove redundant function argumentsnet/ | +5 | 0 replies | Applied |
| 9/9 | bridge: mcast: Constify 'group' argument in br_multicast_new_port_group()net/ net/ | +3 | 1 reply | Applied |
Reviews trailers per patch
All 9 patches have a Reviewed-by or Acked-by.
| Patch | Nikolay Aleksandrov |
|---|---|
| 1/9 | A-b |
| 2/9 | A-b |
| 3/9 | A-b |
| 4/9 | A-b |
| 5/9 | A-b |
| 6/9 | A-b |
| 7/9 | A-b |
| 8/9 | A-b |
| 9/9 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH net-next v2 0/9] bridge: mcast: Preparations for EVPN extensions
This patchset was split from [1] and includes non-functional changes aimed at making it easier to add additional netlink attributes later on. Future extensions are available here [2].
The idea behind these patches is to create an MDB configuration structure into which netlink messages are parsed into. The structure is then passed in the entry creation / deletion call chain instead of passing the netlink attributes themselves. The same pattern is used by other rtnetlink objects such as routes and nexthops.
I initially tried to extend the current code, but it proved to be too difficult, which is why I decided to refactor it to the extensible and familiar pattern used by other rtnetlink objects.
Tested using existing selftests and using a new selftest that will be submitted together with the planned extensions.
v2:
* Patch #1: Remove 'skb' argument from br_mdb_config_init().
* Patch #1: Mark 'nlh' argument as 'const'.
* Patch #4: Pass 'cfg' as 'const'.
* Patch #5: Pass 'cfg' as 'const'.
* Patch #9: New patch.
[1] https://lore.kernel.org/netdev/[email protected]/
[2] https://github.com/idosch/linux/commits/submit/mdb_v1
Ido Schimmel (9):
bridge: mcast: Centralize netlink attribute parsing
bridge: mcast: Remove redundant checks
bridge: mcast: Use MDB configuration structure where possible
bridge: mcast: Propagate MDB configuration structure further
bridge: mcast: Use MDB group key from configuration structure
bridge: mcast: Remove br_mdb_parse()
bridge: mcast: Move checks out of critical section
bridge: mcast: Remove redundant function arguments
bridge: mcast: Constify 'group' argument in
br_multicast_new_port_group()
net/bridge/br_mdb.c | 312 ++++++++++++++++++-------------------- net/bridge/br_multicast.c | 2 +- net/bridge/br_private.h | 10 +- 3 files changed, 159 insertions(+), 165 deletions(-)
Signature · 1 line
2.37.3