Skip to content

bridge: mcast: Preparations for EVPN extensions

Ido Schimmel bridge netdev 2 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (master)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest9 patches 2 repliesApplied 9/9
  2. v18 patches 11 repliesSuperseded

Changes in v2 from the cover letter

* Patch #1: Remove 'skb' argument from br_mdb_config_init().
* Patch #1: Mark 'nlh' argument as 'const'.
* Patch #4: Pass 'cfg' as 'const'.
* Patch #5: Pass 'cfg' as 'const'.
* Patch #9: New patch.

[1] https://lore.kernel.org/netdev/[email protected]/
[2] https://github.com/idosch/linux/commits/submit/mdb_v1

Patches in v2 All 9 applied

#Subject and filesSizeRepliesApplied
1/9bridge: mcast: Centralize netlink attribute parsingnet/bridge/br_mdb.c net/bridge/br_private.h+127 -01 replyApplied
2/9bridge: mcast: Remove redundant checksnet/bridge/br_mdb.c+9 -540 repliesApplied
3/9bridge: mcast: Use MDB configuration structure where possiblenet/bridge/br_mdb.c+15 -190 repliesApplied
4/9bridge: mcast: Propagate MDB configuration structure furthernet/bridge/br_mdb.c+11 -130 repliesApplied
5/9bridge: mcast: Use MDB group key from configuration structurenet/bridge/br_mdb.c+7 -80 repliesApplied
6/9bridge: mcast: Remove br_mdb_parse()net/bridge/br_mdb.c+5 -880 repliesApplied
7/9bridge: mcast: Move checks out of critical sectionnet/bridge/br_mdb.c+18 -180 repliesApplied
8/9bridge: mcast: Remove redundant function argumentsnet/bridge/br_mdb.c+5 -40 repliesApplied
9/9bridge: mcast: Constify 'group' argument in br_multicast_new_port_group()net/bridge/br_multicast.c net/bridge/br_private.h+3 -21 replyApplied

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchNikolay Aleksandrov
1/9A-b
2/9A-b
3/9A-b
4/9A-b
5/9A-b
6/9A-b
7/9A-b
8/9A-b
9/9A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH net-next v2 0/9] bridge: mcast: Preparations for EVPN extensions

This patchset was split from [1] and includes non-functional changes aimed at making it easier to add additional netlink attributes later on. Future extensions are available here [2].

The idea behind these patches is to create an MDB configuration structure into which netlink messages are parsed into. The structure is then passed in the entry creation / deletion call chain instead of passing the netlink attributes themselves. The same pattern is used by other rtnetlink objects such as routes and nexthops.

I initially tried to extend the current code, but it proved to be too difficult, which is why I decided to refactor it to the extensible and familiar pattern used by other rtnetlink objects.

Tested using existing selftests and using a new selftest that will be submitted together with the planned extensions.

v2:
* Patch #1: Remove 'skb' argument from br_mdb_config_init().
* Patch #1: Mark 'nlh' argument as 'const'.
* Patch #4: Pass 'cfg' as 'const'.
* Patch #5: Pass 'cfg' as 'const'.
* Patch #9: New patch.

[1] https://lore.kernel.org/netdev/[email protected]/
[2] https://github.com/idosch/linux/commits/submit/mdb_v1

Ido Schimmel (9):
bridge: mcast: Centralize netlink attribute parsing
bridge: mcast: Remove redundant checks
bridge: mcast: Use MDB configuration structure where possible
bridge: mcast: Propagate MDB configuration structure further
bridge: mcast: Use MDB group key from configuration structure
bridge: mcast: Remove br_mdb_parse()
bridge: mcast: Move checks out of critical section
bridge: mcast: Remove redundant function arguments
bridge: mcast: Constify 'group' argument in
br_multicast_new_port_group()

 net/bridge/br_mdb.c       | 312 ++++++++++++++++++--------------------
 net/bridge/br_multicast.c |   2 +-
 net/bridge/br_private.h   |  10 +-
 3 files changed, 159 insertions(+), 165 deletions(-)
Signature · 1 line
2.37.3