devlink: make sure devlink port registers/unregisters only for registered instance
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest8 patches 10 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | devlink: call devlink_port_register/unregister() on registered instancedrivers/ drivers/ drivers/ +5 more | +60 | 6 replies | |
| 2/8 | netdevsim: call devl_port_register/unregister() on registered instancedrivers/ | +25 | 0 replies | |
| 3/8 | mlxsw: call devl_port_register/unregister() on registered instancedrivers/ drivers/ drivers/ | +55 | 0 replies | |
| 4/8 | nfp: call devl_port_register/unregister() on registered instancedrivers/ | +16 | 0 replies | |
| 5/8 | mlx4: call devl_port_register/unregister() on registered instancedrivers/ | +33 | 0 replies | |
| 6/8 | mlx5: call devl_port_register/unregister() on registered instancedrivers/ drivers/ drivers/ | +27 | 0 replies | |
| 7/8 | devlink: assert if devl_port_register/unregister() is called on unregistered devlink instancenet/ | +2 | 0 replies | |
| 8/8 | devlink: remove port notifications from devlink_register/unregister()net/ | +0 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [patch net-next 0/8] devlink: make sure devlink port registers/unregisters only for registered instance
From: Jiri Pirko <[email protected]>
Currently, the devlink_register() is called as the last thing during driver init phase. For devlink objects, this is fine as the notifications of objects creations are withheld to be send only after devlink instance is registered. Until devlink is registered it is not visible to userspace.
But if a netdev is registered before, user gets a notification with a link to devlink, which is not visible to the user yet. This is the event order user sees:
* new netdev event over RT netlink
* new devlink event over devlink netlink
* new devlink_port event over devlink netlink
Also, this is not consistent with devlink port split or devlink reload flows, where user gets notifications in following order:
* new devlink event over devlink netlink
and then during port split or reload operation:
* new devlink_port event over devlink netlink
* new netdev event over RT netlink
In this case, devlink port and related netdev are registered on already registered devlink instance.
Purpose of this patchset is to fix the drivers init flow so devlink port gets registered only after devlink instance is registered.
Jiri Pirko (8):
devlink: call devlink_port_register/unregister() on registered
instance
netdevsim: call devl_port_register/unregister() on registered instance
mlxsw: call devl_port_register/unregister() on registered instance
nfp: call devl_port_register/unregister() on registered instance
mlx4: call devl_port_register/unregister() on registered instance
mlx5: call devl_port_register/unregister() on registered instance
devlink: assert if devl_port_register/unregister() is called on
unregistered devlink instance
devlink: remove port notifications from devlink_register/unregister()
.../net/ethernet/broadcom/bnxt/bnxt_devlink.c | 29 +++++---- .../net/ethernet/freescale/dpaa2/dpaa2-eth.c | 7 ++- .../ethernet/fungible/funeth/funeth_main.c | 17 ++++-- drivers/net/ethernet/intel/ice/ice_main.c | 21 ++++--- .../ethernet/marvell/prestera/prestera_main.c | 6 +- drivers/net/ethernet/mellanox/mlx4/main.c | 60 ++++++++++--------- drivers/net/ethernet/mellanox/mlx5/core/dev.c | 10 +++- .../net/ethernet/mellanox/mlx5/core/main.c | 17 +++--- .../mellanox/mlx5/core/sf/dev/driver.c | 9 +++ drivers/net/ethernet/mellanox/mlxsw/core.c | 24 ++++++++ drivers/net/ethernet/mellanox/mlxsw/core.h | 2 + .../net/ethernet/mellanox/mlxsw/spectrum.c | 38 +++++++++--- drivers/net/ethernet/mscc/ocelot_vsc7514.c | 10 ++-- .../net/ethernet/netronome/nfp/nfp_net_main.c | 22 +++++-- .../ethernet/pensando/ionic/ionic_devlink.c | 6 +- drivers/net/ethernet/ti/am65-cpsw-nuss.c | 7 ++- drivers/net/netdevsim/dev.c | 31 ++++++++-- net/core/devlink.c | 7 +-- 18 files changed, 218 insertions(+), 105 deletions(-)
Signature · 1 line
2.37.3