Skip to content

Support 'make dist' and 'make check'

Phil Sutter netfilter-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest11 patches 1 replyIn review
  2. v111 patches 7 repliesSuperseded

Changes in v2 from the cover letter

- Replace bashism in patch 3.
- Generate .tar.xz instead of .tar.bz2 in patch 8.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11Drop INCOMPATIBILITIES fileINCOMPATIBILITIES+0 -140 replies
2/11Drop libiptc/linux_stddef.hlibiptc/linux_stddef.h+0 -390 replies
3/11Makefile: Generate ip6tables man pages on the flyiptables/Makefile.am iptables/ip6tables-apply.8 iptables/ip6tables-restore.8 +2 more+3 -40 replies
4/11extensions: Makefile: Merge initext targetsextensions/GNUmakefile.in+14 -920 replies
5/11iptables/Makefile: Reorg variable assignmentsiptables/Makefile.am+32 -260 replies
6/11iptables/Makefile: Split nft-variant man page listiptables/Makefile.am+7 -110 replies
7/11Makefile: Fix for 'make distcheck'Makefile.am extensions/GNUmakefile.in include/Makefile.am +4 more+28 -60 replies
8/11Makefile: Generate .tar.xz archive with 'make dist'Makefile.am+1 -10 replies
9/11include/Makefile: xtables-version.h is generatedinclude/Makefile.am+3 -30 replies
10/11tests: Adjust testsuite return codes to automake guidelinesiptables-test.py iptables/tests/shell/run-tests.sh xlate-test.py+5 -30 replies
11/11Makefile.am: Integrate testsuites.gitignore Makefile.am+14 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [iptables PATCH v2 00/11] Support 'make dist' and 'make check'

The goal of this series is to replace the custom 'tarball' Makefile target by automake's standard 'dist' target. Due to the special non-automake extensions/GNUMakefile.in and some other minor details, this hasn't been functional.

Patches 1-6 are preparation work and cleanup of left-overs noticed when comparing final tarball contents.

Patches 7 and 8 then enable 'dist' and 'distcheck' targets.

Finally, patches 9 and 10 integrate testsuite scripts for use with 'make check'. The 'distcheck' target triggers them, too. But since one doesn't do that as uid 0, only xlate-test.py actually executes and the others are skipped.

Changes since v1:
- Replace bashism in patch 3.
- Generate .tar.xz instead of .tar.bz2 in patch 8.

Phil Sutter (11):
Drop INCOMPATIBILITIES file
Drop libiptc/linux_stddef.h
Makefile: Generate ip6tables man pages on the fly
extensions: Makefile: Merge initext targets iptables/Makefile: Reorg variable assignments iptables/Makefile: Split nft-variant man page list
Makefile: Fix for 'make distcheck'
Makefile: Generate .tar.xz archive with 'make dist' include/Makefile: xtables-version.h is generated
tests: Adjust testsuite return codes to automake guidelines Makefile.am: Integrate testsuites

 .gitignore                        |  12 +++
 INCOMPATIBILITIES                 |  14 ----
 Makefile.am                       |   8 +-
 extensions/GNUmakefile.in         | 121 +++++++-----------------------
 include/Makefile.am               |   8 +-
 iptables-test.py                  |   2 +-
 iptables/Makefile.am              |  84 +++++++++++----------
 iptables/ip6tables-apply.8        |   1 -
 iptables/ip6tables-restore.8      |   1 -
 iptables/ip6tables-save.8         |   1 -
 iptables/ip6tables.8              |   1 -
 iptables/tests/shell/run-tests.sh |   4 +-
 libipq/Makefile.am                |   2 +-
 libiptc/Makefile.am               |   2 +
 libiptc/linux_stddef.h            |  39 ----------
 utils/Makefile.am                 |   4 +-
 xlate-test.py                     |   2 +-
 17 files changed, 107 insertions(+), 199 deletions(-)
 delete mode 100644 INCOMPATIBILITIES
 delete mode 100644 iptables/ip6tables-apply.8
 delete mode 100644 iptables/ip6tables-restore.8
 delete mode 100644 iptables/ip6tables-save.8
 delete mode 100644 iptables/ip6tables.8
 delete mode 100644 libiptc/linux_stddef.h
Signature · 1 line
2.38.0