Skip to content

KVM: selftests: Fixes for ucall pool + page_fault_test

Oliver Upton kvm kvmarm linux-arm-kernel linux-kselftest lkml llvm 2 versions – Applied

Status from this message: Queued 3+5, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest7 patches 9 repliesApplied
  2. v14 patches 14 repliesSuperseded

Changes in v2 from the cover letter

- Collect R-b from Sean (thanks!)
- Use a common routine for split and contiguous VA spaces, with commentary on why arm64 is different since we all get to look at it now. (Sean)
- Don't identity map the ucall MMIO hole
- Fix an off-by-one issue in the accounting of virtual memory, discovered in fighting with #2
- Fix an infinite loop in ucall_alloc(), discovered fighting with the ucall_init() v. kvm_vm_elf_load() ordering issue

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/7KVM: selftests: Fix build due to ucall_uninit() removaltools/testing/selftests/kvm/aarch64/page_fault_test.c+0 -10 replies
2/7KVM: selftests: Setup ucall after loading program into guest memorytools/testing/selftests/kvm/aarch64/page_fault_test.c+7 -10 replies
3/7KVM: selftests: Mark correct page as mapped in virt_map()tools/testing/selftests/kvm/lib/kvm_util.c+2 -20 replies
4/7KVM: selftests: Correctly initialize the VA space for TTBR0_EL1tools/testing/selftests/kvm/include/kvm_util_base.h tools/testing/selftests/kvm/lib/kvm_util.c+44 -63 replies
5/7KVM: arm64: selftests: Don't identity map the ucall MMIO holetools/testing/selftests/kvm/lib/aarch64/ucall.c+4 -20 replies
6/7KVM: selftests: Allocate ucall pool from MEM_REGION_DATAtools/testing/selftests/kvm/lib/ucall_common.c+1 -10 replies
7/7KVM: selftests: Avoid infinite loop if ucall_alloc() failstools/testing/selftests/kvm/lib/ucall_common.c+10 -23 replies

Reviews trailers per patch

2 of 7 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchSean ChristophersonAndrew Jones
SeriesR-b
1/7
2/7
3/7
4/7R-b
5/7
6/7R-b
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/7] KVM: selftests: Fixes for ucall pool + page_fault_test

The combination of the pool-based ucall implementation + page_fault_test resulted in some 'fun' bugs. As has always been the case, KVM selftests is a house of cards.

Small series to fix up the issues on kvm/queue. Patches 1-2 can probably be squashed into Paolo's merge resolution, if desired.

Tested on Ampere Altra and a Skylake box, since there was a decent amount of munging in architecture-generic code.

v1 -> v2:
- Collect R-b from Sean (thanks!)
- Use a common routine for split and contiguous VA spaces, with commentary on why arm64 is different since we all get to look at it now. (Sean)
- Don't identity map the ucall MMIO hole
- Fix an off-by-one issue in the accounting of virtual memory, discovered in fighting with #2
- Fix an infinite loop in ucall_alloc(), discovered fighting with the ucall_init() v. kvm_vm_elf_load() ordering issue

Mark Brown (1):
KVM: selftests: Fix build due to ucall_uninit() removal

Oliver Upton (6):
KVM: selftests: Setup ucall after loading program into guest memory
KVM: selftests: Mark correct page as mapped in virt_map()
KVM: selftests: Correctly initialize the VA space for TTBR0_EL1
KVM: arm64: selftests: Don't identity map the ucall MMIO hole
KVM: selftests: Allocate ucall pool from MEM_REGION_DATA
KVM: selftests: Avoid infinite loop if ucall_alloc() fails

 .../selftests/kvm/aarch64/page_fault_test.c   |  9 +++-
 .../selftests/kvm/include/kvm_util_base.h     |  1 +
 .../testing/selftests/kvm/lib/aarch64/ucall.c |  6 ++-
 tools/testing/selftests/kvm/lib/kvm_util.c    | 53 ++++++++++++++++---
 .../testing/selftests/kvm/lib/ucall_common.c  | 14 +++--
 5 files changed, 68 insertions(+), 15 deletions(-)

base-commit: 89b2395859651113375101bb07cd6340b1ba3637

Signature · 6 lines
2.39.0.rc1.256.g54fd8350bd-goog

_______________________________________________
kvmarm mailing list
[email protected]
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm