KVM: selftests: Fixes for ucall pool + page_fault_test
Status from this message: Queued 3+5, thanks.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest7 patches 9 repliesApplied
- v14 patches 14 repliesSuperseded
Changes in v2 from the cover letter
- Collect R-b from Sean (thanks!)
- Use a common routine for split and contiguous VA spaces, with commentary on why arm64 is different since we all get to look at it now. (Sean)
- Don't identity map the ucall MMIO hole
- Fix an off-by-one issue in the accounting of virtual memory, discovered in fighting with #2
- Fix an infinite loop in ucall_alloc(), discovered fighting with the ucall_init() v. kvm_vm_elf_load() ordering issue
Patches in v2 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | KVM: selftests: Fix build due to ucall_uninit() removaltools/ | +0 | 0 replies | |
| 2/7 | KVM: selftests: Setup ucall after loading program into guest memorytools/ | +7 | 0 replies | |
| 3/7 | KVM: selftests: Mark correct page as mapped in virt_map()tools/ | +2 | 0 replies | |
| 4/7 | KVM: selftests: Correctly initialize the VA space for TTBR0_EL1tools/ tools/ | +44 | 3 replies | |
| 5/7 | KVM: arm64: selftests: Don't identity map the ucall MMIO holetools/ | +4 | 0 replies | |
| 6/7 | KVM: selftests: Allocate ucall pool from MEM_REGION_DATAtools/ | +1 | 0 replies | |
| 7/7 | KVM: selftests: Avoid infinite loop if ucall_alloc() failstools/ | +10 | 3 replies |
Reviews trailers per patch
2 of 7 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Sean Christopherson | Andrew Jones |
|---|---|---|
| Series | R-b | |
| 1/7 | ||
| 2/7 | ||
| 3/7 | ||
| 4/7 | R-b | |
| 5/7 | ||
| 6/7 | R-b | |
| 7/7 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/7] KVM: selftests: Fixes for ucall pool + page_fault_test
The combination of the pool-based ucall implementation + page_fault_test resulted in some 'fun' bugs. As has always been the case, KVM selftests is a house of cards.
Small series to fix up the issues on kvm/queue. Patches 1-2 can probably be squashed into Paolo's merge resolution, if desired.
Tested on Ampere Altra and a Skylake box, since there was a decent amount of munging in architecture-generic code.
v1 -> v2:
- Collect R-b from Sean (thanks!)
- Use a common routine for split and contiguous VA spaces, with commentary on why arm64 is different since we all get to look at it now. (Sean)
- Don't identity map the ucall MMIO hole
- Fix an off-by-one issue in the accounting of virtual memory, discovered in fighting with #2
- Fix an infinite loop in ucall_alloc(), discovered fighting with the ucall_init() v. kvm_vm_elf_load() ordering issue
Mark Brown (1):
KVM: selftests: Fix build due to ucall_uninit() removal
Oliver Upton (6):
KVM: selftests: Setup ucall after loading program into guest memory
KVM: selftests: Mark correct page as mapped in virt_map()
KVM: selftests: Correctly initialize the VA space for TTBR0_EL1
KVM: arm64: selftests: Don't identity map the ucall MMIO hole
KVM: selftests: Allocate ucall pool from MEM_REGION_DATA
KVM: selftests: Avoid infinite loop if ucall_alloc() fails
.../selftests/kvm/aarch64/page_fault_test.c | 9 +++- .../selftests/kvm/include/kvm_util_base.h | 1 + .../testing/selftests/kvm/lib/aarch64/ucall.c | 6 ++- tools/testing/selftests/kvm/lib/kvm_util.c | 53 ++++++++++++++++--- .../testing/selftests/kvm/lib/ucall_common.c | 14 +++-- 5 files changed, 68 insertions(+), 15 deletions(-)
base-commit: 89b2395859651113375101bb07cd6340b1ba3637
Signature · 6 lines
2.39.0.rc1.256.g54fd8350bd-goog _______________________________________________ kvmarm mailing list [email protected] https://lists.cs.columbia.edu/mailman/listinfo/kvmarm