Skip to content

blk-cgroup: Fix potential UAF & flush rstat at blkgs destruction path

Waiman Long cgroups linux-block linux-mm lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest2 patches 3 repliesIn review
  2. v32 patches 6 repliesSuperseded
  3. v23 patches 8 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v13 patches2 repliesSuperseded

Changes in v4 from the cover letter

- Update comment and commit logs for both patches.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2bdi, blk-cgroup: Fix potential UAF of blkcgblock/blk-cgroup.c mm/backing-dev.c+13 -20 replies
2/2blk-cgroup: Flush stats at blkgs destruction pathblock/blk-cgroup.c include/linux/cgroup.h kernel/cgroup/rstat.c+35 -02 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchTejun Heo
1/2A-b
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/2] blk-cgroup: Fix potential UAF & flush rstat at blkgs destruction path

v4:
- Update comment and commit logs for both patches.

v3:
- Drop v2 patch 2 as it may not be needed.
- Replace css_tryget() with percpu_ref_is_zero() in patch 1 as suggested by Tejun.
- Expand comment on patch 2 to elaborate the reason for this patch.

v2:
- Remove unnecessary rcu_read_{lock|unlock} from cgroup_rstat_css_cpu_flush() in patch 3.

It was found that blkcg_destroy_blkgs() may be called with all blkcg references gone. This may potentially cause user-after-free and so should be fixed. The second patch flushes rstat when calling blkcg_destroy_blkgs().

Waiman Long (2):
bdi, blk-cgroup: Fix potential UAF of blkcg
blk-cgroup: Flush stats at blkgs destruction path

 block/blk-cgroup.c     | 23 +++++++++++++++++++++++
 include/linux/cgroup.h |  1 +
 kernel/cgroup/rstat.c  | 18 ++++++++++++++++++
 mm/backing-dev.c       |  8 ++++++--
 4 files changed, 48 insertions(+), 2 deletions(-)
Signature · 1 line
2.31.1