Skip to content

ASoC: SOF: remove unregister calls from shutdown

Kai Vehmanen alsa-devel regressions 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 10 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ASoC: SOF: Intel: pci-tgl: unblock S5 entry if DMA stop has failed"sound/soc/sof/intel/hda-dsp.c sound/soc/sof/intel/hda.h sound/soc/sof/intel/tgl.c+74 -11 reply
2/2ASoC: SOF: Revert: "core: unregister clients and machine drivers in .shutdown"sound/soc/sof/core.c+0 -93 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchPierre-Louis BossartPéter UjfalusiRanjani SridharanRicardo Ribalda
1/2R-b R-b R-b T-b
2/2R-b R-b R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH 0/2] ASoC: SOF: remove unregister calls from shutdown

This patchset is an alternative solution to problems reported by Ricardo Ribalda <[email protected]> and Zhen Ni <[email protected]>, as discussed in

- "[PATCH] ALSA: core: Fix deadlock when shutdown a frozen userspace"
https://mailman.alsa-project.org/pipermail/alsa-devel/2022-November/209248.html

- "[PATCH] ASoc: SOF: Fix sof-audio-pci-intel-tgl shutdown timeout during hibernation"
https://mailman.alsa-project.org/pipermail/alsa-devel/2022-December/209685.html

It was raised by Oliver Neukum <[email protected]> that kernel should not let user-space stall the shutdown process in any scenario and the unregister call in current SOF shutdown code is not right.

This series reverts the ASoC SOF patch to unregister clients and the machine drivers at shutdown. To avoid bringing back old bugs, the series includes a patch to fix S5 entry on certain Intel platforms.

Kai Vehmanen (2):
ASoC: SOF: Intel: pci-tgl: unblock S5 entry if DMA stop has failed"
ASoC: SOF: Revert: "core: unregister clients and machine drivers in
.shutdown"

 sound/soc/sof/core.c          |  9 -----
 sound/soc/sof/intel/hda-dsp.c | 72 +++++++++++++++++++++++++++++++++++
 sound/soc/sof/intel/hda.h     |  1 +
 sound/soc/sof/intel/tgl.c     |  2 +-
 4 files changed, 74 insertions(+), 10 deletions(-)

base-commit: e85b1f5a9769ac30f4d2f6fb1cdcd9570c38e0c1

Signature · 1 line
2.38.1