hw/ppc: Clean up includes
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest4 patches 7 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | include/hw/ppc: Split pnv_chip.h off pnv.hhw/ hw/ hw/ +8 more | +160 | 1 reply | |
| 2/4 | include/hw/ppc: Supply a few missing includesinclude/ include/ include/ +4 more | +13 | 1 reply | |
| 3/4 | include/hw/ppc: Don't include hw/pci-host/pnv_phb.h from pnv.hhw/ hw/ include/ +1 more | +6 | 2 replies | |
| 4/4 | include/hw/ppc include/hw/pci-host: Drop extra typedefshw/ include/ include/ +4 more | +7 | 2 replies |
Reviews trailers per patch
All 4 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Cédric Le Goater | Philippe Mathieu-Daudé | Daniel Henrique Barboza |
|---|---|---|---|
| Series | R-b | ||
| 1/4 | R-b | ||
| 2/4 | R-b | ||
| 3/4 | R-b | ||
| 4/4 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH 0/4] hw/ppc: Clean up includes
Back in 2016, we discussed[1] rules for headers, and these were generally liked:
1. Have a carefully curated header that's included everywhere first. We got that already thanks to Peter: osdep.h.
2. Headers should normally include everything they need beyond osdep.h. If exceptions are needed for some reason, they must be documented in the header. If all that's needed from a header is typedefs, put those into qemu/typedefs.h instead of including the header.
3. Cyclic inclusion is forbidden.
After this series, include/hw/ppc and include/hw/pci-host/pnv* conform to these rules.
It is based on
[PATCH 0/5] include/hw/pci include/hw/cxl: Clean up includes [PATCH 0/3] block: Clean up includes
[PATCH 0/4] coroutine: Clean up includes
[1] Message-ID: <[email protected]>
https://lists.nongnu.org/archive/html/qemu-devel/2016-03/msg03345.html
Based-on: <[email protected]>
Markus Armbruster (4):
include/hw/ppc: Split pnv_chip.h off pnv.h include/hw/ppc: Supply a few missing includes include/hw/ppc: Don't include hw/pci-host/pnv_phb.h from pnv.h include/hw/ppc include/hw/pci-host: Drop extra typedefs
hw/pci-host/pnv_phb.h | 2 +- include/hw/pci-host/pnv_phb3.h | 1 - include/hw/pci-host/pnv_phb4.h | 5 +- include/hw/ppc/pnv.h | 146 +------------------------------- include/hw/ppc/pnv_chip.h | 147 +++++++++++++++++++++++++++++++++ include/hw/ppc/pnv_core.h | 3 +- include/hw/ppc/pnv_homer.h | 2 +- include/hw/ppc/pnv_lpc.h | 11 +-- include/hw/ppc/pnv_occ.h | 3 +- include/hw/ppc/pnv_pnor.h | 2 +- include/hw/ppc/pnv_sbe.h | 3 +- include/hw/ppc/pnv_xive.h | 7 +- include/hw/ppc/pnv_xscom.h | 3 +- include/hw/ppc/xive2.h | 2 + include/hw/ppc/xive2_regs.h | 2 + hw/intc/pnv_xive.c | 1 + hw/intc/pnv_xive2.c | 1 + hw/pci-host/pnv_phb3.c | 1 + hw/pci-host/pnv_phb4_pec.c | 1 + hw/ppc/pnv.c | 3 + hw/ppc/pnv_core.c | 1 + hw/ppc/pnv_homer.c | 1 + hw/ppc/pnv_lpc.c | 1 + hw/ppc/pnv_psi.c | 1 + hw/ppc/pnv_xscom.c | 1 + 25 files changed, 186 insertions(+), 165 deletions(-) create mode 100644 include/hw/ppc/pnv_chip.h
Signature · 1 line
2.37.3