Skip to content

coroutine: Clean up includes

Markus Armbruster qemu-devel 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 posting 3/34 patches 0 repliesNew
  2. v2 posting 2/33 patches 0 repliesSuperseded
  3. v3 Latest5 patches 7 repliesIn review
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v2 posting 1/35 patches2 repliesSuperseded
v12 patches6 repliesSuperseded

Changes in v3 from the cover letter

* PATCH 4: Unnecessary hunks dropped

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5coroutine: Clean up superfluous inclusion of qemu/coroutine.hblockjob.c crypto/block-luks-priv.h crypto/block-luks.c +12 more+0 -150 replies
2/5coroutine: Move coroutine_fn to qemu/osdep.h, trim includesinclude/block/aio_task.h include/block/block-common.h include/block/graph-lock.h +3 more+23 -170 replies
3/5coroutine: Clean up superfluous inclusion of qemu/lockable.hblock/progress_meter.c include/qemu/progress_meter.h tests/unit/test-coroutine.c+3 -20 replies
4/5coroutine: Split qemu/coroutine-core.h off qemu/coroutine.hhw/9pfs/coth.h include/block/aio.h include/io/channel.h +7 more+162 -1023 replies
5/5coroutine: Use Coroutine typedef name instead of structure taginclude/block/aio.h util/async.c+5 -60 replies

Reviews trailers per patch

4 of 5 patches have a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-DaudéStefan Hajnoczi
SeriesT-b
1/5R-b
2/5R-b
3/5R-b
4/5
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/5] coroutine: Clean up includes

v3:
* PATCH 4: Unnecessary hunks dropped

v2:
* Rebased
* PATCH 4: Rewritten [Paolo]
* PATCH 5: New

Markus Armbruster (5):
coroutine: Clean up superfluous inclusion of qemu/coroutine.h
coroutine: Move coroutine_fn to qemu/osdep.h, trim includes
coroutine: Clean up superfluous inclusion of qemu/lockable.h
coroutine: Split qemu/coroutine-core.h off qemu/coroutine.h
coroutine: Use Coroutine typedef name instead of structure tag

 crypto/block-luks-priv.h      |   1 -
 hw/9pfs/coth.h                |   2 +-
 include/block/aio.h           |   9 +-
 include/block/aio_task.h      |   2 -
 include/block/block-common.h  |   1 -
 include/block/graph-lock.h    |   2 -
 include/block/raw-aio.h       |   1 -
 include/io/channel.h          |   2 +-
 include/monitor/hmp.h         |   1 -
 include/qemu/coroutine-core.h | 154 ++++++++++++++++++++++++++++++++++
 include/qemu/coroutine.h      | 113 ++-----------------------
 include/qemu/lockable.h       |   2 +-
 include/qemu/osdep.h          |  16 ++++
 include/qemu/progress_meter.h |   2 +-
 include/qemu/typedefs.h       |   1 -
 include/scsi/pr-manager.h     |   1 -
 nbd/nbd-internal.h            |   1 -
 block/progress_meter.c        |   2 +
 blockjob.c                    |   1 -
 crypto/block-luks.c           |   1 -
 hw/9pfs/codir.c               |   1 -
 hw/9pfs/cofile.c              |   1 -
 hw/9pfs/cofs.c                |   1 -
 hw/9pfs/coxattr.c             |   1 -
 nbd/client-connection.c       |   1 +
 tests/unit/test-aio.c         |   2 +-
 tests/unit/test-coroutine.c   |   2 -
 tests/unit/test-vmstate.c     |   1 -
 ui/console.c                  |   1 +
 util/async.c                  |   4 +-
 util/qemu-coroutine-lock.c    |   1 -
 util/qemu-coroutine-sleep.c   |   1 -
 util/qemu-coroutine.c         |   1 -
 33 files changed, 192 insertions(+), 141 deletions(-)
 create mode 100644 include/qemu/coroutine-core.h
Signature · 1 line
2.38.1