Skip to content

hw/mips/malta: Generate nanoMIPS bootloader with bootloader generator API

Philippe Mathieu-Daudé qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest11 patches 12 repliesIn review
  2. v17 patches 13 repliesSuperseded

Changes in v2 from the cover letter

- addressed review comments
- generate JALRc
- split write_bootloader_nanomips() convertion in 5 parts
- use bl_gen_jump_kernel()
- merge common code to bl_setup_gt64120_jump_kernel()

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11hw/mips/bootloader: Handle buffers as opaque arrayshw/mips/bootloader.c hw/mips/malta.c include/hw/mips/bootloader.h+48 -362 replies
2/11hw/mips/bootloader: Implement nanoMIPS NOP opcode generatorhw/mips/bootloader.c+20 -40 replies
3/11hw/mips/bootloader: Implement nanoMIPS SW opcode generatorhw/mips/bootloader.c+19 -11 reply
4/11hw/mips/bootloader: Implement nanoMIPS LI (LUI+ORI) opcode generatorhw/mips/bootloader.c+34 -21 reply
5/11hw/mips/bootloader: Implement nanoMIPS JALRc opcode generatorhw/mips/bootloader.c+11 -11 reply
6/11hw/mips/malta: Use bootloader generator API for nanoMIPS CPUs (1/5)hw/mips/malta.c+15 -191 reply
7/11hw/mips/malta: Use bootloader generator API for nanoMIPS CPUs (2/5)hw/mips/malta.c+6 -291 reply
8/11hw/mips/malta: Use bootloader generator API for nanoMIPS CPUs (3/5)hw/mips/malta.c+8 -321 reply
9/11hw/mips/malta: Use bootloader generator API for nanoMIPS CPUs (4/5)hw/mips/malta.c+7 -331 reply
10/11hw/mips/malta: Use bootloader generator API for nanoMIPS CPUs (5/5)hw/mips/malta.c+11 -571 reply
11/11hw/mips/malta: Merge common BL code as bl_setup_gt64120_jump_kernel()hw/mips/malta.c+56 -991 reply

Reviews trailers per patch

All 11 patches have a Reviewed-by or Acked-by.

PatchRichard Henderson
1/11R-b
2/11R-b
3/11R-b
4/11R-b
5/11R-b
6/11R-b
7/11R-b
8/11R-b
9/11R-b
10/11R-b
11/11R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH-for-8.0 v2 00/11] hw/mips/malta: Generate nanoMIPS bootloader with bootloader generator API

Bernhard posted his "Consolidate PIIX south bridges" v3 series:
https://lore.kernel.org/qemu-devel/[email protected]/

However in order to simplify it, on the Malta board we need to set the PIIX IRQC[A:D] routing values via the embedded bootloader (used when no external BIOS is provided). Jiaxun added a "bootloader generator API" for 32-bit wide instructions, and we use it in the write_bootloader() function.
This series provides the nanoMIPS equivalent generated instructions and update the write_bootloader_nanomips() function. That allow fixing the TODO left in
https://lore.kernel.org/qemu-devel/[email protected]/
and apply Bernhard's consolidation.

Since v1:
- addressed review comments
- generate JALRc
- split write_bootloader_nanomips() convertion in 5 parts
- use bl_gen_jump_kernel()
- merge common code to bl_setup_gt64120_jump_kernel()

Philippe Mathieu-Daudé (11):
hw/mips/bootloader: Handle buffers as opaque arrays hw/mips/bootloader: Implement nanoMIPS NOP opcode generator hw/mips/bootloader: Implement nanoMIPS SW opcode generator hw/mips/bootloader: Implement nanoMIPS LI (LUI+ORI) opcode generator hw/mips/bootloader: Implement nanoMIPS JALRc opcode generator hw/mips/malta: Use bootloader generator API for nanoMIPS CPUs (1/5) hw/mips/malta: Use bootloader generator API for nanoMIPS CPUs (2/5) hw/mips/malta: Use bootloader generator API for nanoMIPS CPUs (3/5) hw/mips/malta: Use bootloader generator API for nanoMIPS CPUs (4/5) hw/mips/malta: Use bootloader generator API for nanoMIPS CPUs (5/5) hw/mips/malta: Merge common BL code as bl_setup_gt64120_jump_kernel()

 hw/mips/bootloader.c         | 141 ++++++++++++++----
 hw/mips/malta.c              | 281 ++++++++---------------------------
 include/hw/mips/bootloader.h |  10 +-
 3 files changed, 177 insertions(+), 255 deletions(-)
Signature · 1 line
2.38.1