Remove COMMAND_LINE_SIZE from uapi
Get series with b4
b4 am [email protected]Versions newest first
- v2 Latest24 patches 5 repliesIn review
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/24 | alpha: Remove COMMAND_LINE_SIZE from uapiarch/ arch/ | +2 | 0 replies | |
| 2/24 | arm: Remove COMMAND_LINE_SIZE from uapiarch/ arch/ | +1 | 0 replies | |
| 3/24 | arm64: Remove COMMAND_LINE_SIZE from uapiarch/ arch/ | +2 | 0 replies | |
| 4/24 | ia64: Remove COMMAND_LINE_SIZE from uapiarch/ arch/ | +10 | 0 replies | |
| 5/24 | m68k: Remove COMMAND_LINE_SIZE from uapiarch/ arch/ | +1 | 1 reply | |
| 6/24 | microblaze: Remove COMMAND_LINE_SIZE from uapiarch/ arch/ | +1 | 0 replies | |
| 7/24 | mips: Remove COMMAND_LINE_SIZE from uapiarch/ arch/ | +2 | 0 replies | |
| 8/24 | parisc: Remove COMMAND_LINE_SIZE from uapiarch/ arch/ | +7 | 0 replies | |
| 9/24 | powerpc: Remove COMMAND_LINE_SIZE from uapiarch/ arch/ | +1 | 0 replies | |
| 10/24 | sparc: Remove COMMAND_LINE_SIZE from uapiarch/ arch/ | +5 | 0 replies | |
| 11/24 | xtensa: Remove COMMAND_LINE_SIZE from uapiarch/ arch/ | +17 | 0 replies | |
| 12/24 | asm-generic: Remove COMMAND_LINE_SIZE from uapiDocumentation/ arch/ include/ +1 more | +2 | 0 replies | |
| 13/24 | alpha: Remove empty <uapi/asm/setup.h>arch/ | +0 | 0 replies | |
| 14/24 | arc: Remove empty <uapi/asm/setup.h>arch/ arch/ | +0 | 0 replies | |
| 15/24 | arm64: Remove empty <uapi/asm/setup.h>arch/ | +0 | 0 replies | |
| 16/24 | m68k: Remove empty <uapi/asm/setup.h>arch/ | +0 | 1 reply | |
| 17/24 | microblaze: Remove empty <uapi/asm/setup.h>arch/ | +0 | 0 replies | |
| 18/24 | mips: Remove empty <uapi/asm/setup.h>arch/ | +0 | 0 replies | |
| 19/24 | parisc: Remove empty <uapi/asm/setup.h>arch/ | +0 | 0 replies | |
| 20/24 | powerpc: Remove empty <uapi/asm/setup.h>arch/ | +0 | 0 replies | |
| 21/24 | s390: Remove empty <uapi/asm/setup.h>arch/ arch/ | +0 | 0 replies | |
| 22/24 | sparc: Remove empty <uapi/asm/setup.h>arch/ | +0 | 0 replies | |
| 23/24 | x86: Remove empty <uapi/asm/setup.h>arch/ arch/ | +0 | 0 replies | |
| 24/24 | xtensa: Remove empty <uapi/asm/setup.h>arch/ | +0 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCH v2 00/24] Remove COMMAND_LINE_SIZE from uapi
This all came up in the context of increasing COMMAND_LINE_SIZE in the RISC-V port. In theory that's a UABI break, as COMMAND_LINE_SIZE is the maximum length of /proc/cmdline and userspace could staticly rely on that to be correct.
Usually I wouldn't mess around with changing this sort of thing, but PowerPC increased it with a5980d064fe2 ("powerpc: Bump COMMAND_LINE_SIZE to 2048"). There are also a handful of examples of COMMAND_LINE_SIZE increasing, but they're from before the UAPI split so I'm not quite sure what that means: e5a6a1c90948 ("powerpc: derive COMMAND_LINE_SIZE from asm-generic"), 684d2fd48e71 ("[S390] kernel: Append scpdata to kernel boot command line"), 22242681cff5 ("MIPS: Extend COMMAND_LINE_SIZE"), and 2b74b85693c7 ("sh: Derive COMMAND_LINE_SIZE from asm-generic/setup.h.").
It seems to me like COMMAND_LINE_SIZE really just shouldn't have been part of the uapi to begin with, and userspace should be able to handle /proc/cmdline of whatever length it turns out to be. I don't see any references to COMMAND_LINE_SIZE anywhere but Linux via a quick Google search, but that's not really enough to consider it unused on my end.
The feedback on the v1 seemed to indicate that COMMAND_LINE_SIZE really shouldn't be part of uapi, so this now touches all the ports. I've tried to split this all out and leave it bisectable, but I haven't tested it all that aggressively.
Changes since v1 <https://lore.kernel.org/all/[email protected]/>:
* Touches every arch.