Skip to content

Remove COMMAND_LINE_SIZE from uapi

Palmer Dabbelt linux-arch linux-m68k lkml oe-kbuild-all 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest24 patches 5 repliesIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/24alpha: Remove COMMAND_LINE_SIZE from uapiarch/alpha/include/asm/setup.h arch/alpha/include/uapi/asm/setup.h+2 -40 replies
2/24arm: Remove COMMAND_LINE_SIZE from uapiarch/arm/include/asm/setup.h arch/arm/include/uapi/asm/setup.h+1 -20 replies
3/24arm64: Remove COMMAND_LINE_SIZE from uapiarch/arm64/include/asm/setup.h arch/arm64/include/uapi/asm/setup.h+2 -30 replies
4/24ia64: Remove COMMAND_LINE_SIZE from uapiarch/ia64/include/asm/setup.h arch/ia64/include/uapi/asm/setup.h+10 -40 replies
5/24m68k: Remove COMMAND_LINE_SIZE from uapiarch/m68k/include/asm/setup.h arch/m68k/include/uapi/asm/setup.h+1 -41 reply
6/24microblaze: Remove COMMAND_LINE_SIZE from uapiarch/microblaze/include/asm/setup.h arch/microblaze/include/uapi/asm/setup.h+1 -30 replies
7/24mips: Remove COMMAND_LINE_SIZE from uapiarch/mips/include/asm/setup.h arch/mips/include/uapi/asm/setup.h+2 -40 replies
8/24parisc: Remove COMMAND_LINE_SIZE from uapiarch/parisc/include/asm/setup.h arch/parisc/include/uapi/asm/setup.h+7 -20 replies
9/24powerpc: Remove COMMAND_LINE_SIZE from uapiarch/powerpc/include/asm/setup.h arch/powerpc/include/uapi/asm/setup.h+1 -30 replies
10/24sparc: Remove COMMAND_LINE_SIZE from uapiarch/sparc/include/asm/setup.h arch/sparc/include/uapi/asm/setup.h+5 -80 replies
11/24xtensa: Remove COMMAND_LINE_SIZE from uapiarch/xtensa/include/asm/setup.h arch/xtensa/include/uapi/asm/setup.h+17 -20 replies
12/24asm-generic: Remove COMMAND_LINE_SIZE from uapiDocumentation/admin-guide/kernel-parameters.rst arch/loongarch/include/asm/setup.h include/asm-generic/setup.h +1 more+2 -30 replies
13/24alpha: Remove empty <uapi/asm/setup.h>arch/alpha/include/uapi/asm/setup.h+0 -50 replies
14/24arc: Remove empty <uapi/asm/setup.h>arch/arc/include/asm/setup.h arch/arc/include/uapi/asm/setup.h+0 -70 replies
15/24arm64: Remove empty <uapi/asm/setup.h>arch/arm64/include/uapi/asm/setup.h+0 -250 replies
16/24m68k: Remove empty <uapi/asm/setup.h>arch/m68k/include/uapi/asm/setup.h+0 -151 reply
17/24microblaze: Remove empty <uapi/asm/setup.h>arch/microblaze/include/uapi/asm/setup.h+0 -180 replies
18/24mips: Remove empty <uapi/asm/setup.h>arch/mips/include/uapi/asm/setup.h+0 -50 replies
19/24parisc: Remove empty <uapi/asm/setup.h>arch/parisc/include/uapi/asm/setup.h+0 -50 replies
20/24powerpc: Remove empty <uapi/asm/setup.h>arch/powerpc/include/uapi/asm/setup.h+0 -50 replies
21/24s390: Remove empty <uapi/asm/setup.h>arch/s390/include/asm/setup.h arch/s390/include/uapi/asm/setup.h+0 -20 replies
22/24sparc: Remove empty <uapi/asm/setup.h>arch/sparc/include/uapi/asm/setup.h+0 -90 replies
23/24x86: Remove empty <uapi/asm/setup.h>arch/x86/include/asm/setup.h arch/x86/include/uapi/asm/setup.h+0 -30 replies
24/24xtensa: Remove empty <uapi/asm/setup.h>arch/xtensa/include/uapi/asm/setup.h+0 -150 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 00/24] Remove COMMAND_LINE_SIZE from uapi

This all came up in the context of increasing COMMAND_LINE_SIZE in the RISC-V port. In theory that's a UABI break, as COMMAND_LINE_SIZE is the maximum length of /proc/cmdline and userspace could staticly rely on that to be correct.

Usually I wouldn't mess around with changing this sort of thing, but PowerPC increased it with a5980d064fe2 ("powerpc: Bump COMMAND_LINE_SIZE to 2048"). There are also a handful of examples of COMMAND_LINE_SIZE increasing, but they're from before the UAPI split so I'm not quite sure what that means: e5a6a1c90948 ("powerpc: derive COMMAND_LINE_SIZE from asm-generic"), 684d2fd48e71 ("[S390] kernel: Append scpdata to kernel boot command line"), 22242681cff5 ("MIPS: Extend COMMAND_LINE_SIZE"), and 2b74b85693c7 ("sh: Derive COMMAND_LINE_SIZE from asm-generic/setup.h.").

It seems to me like COMMAND_LINE_SIZE really just shouldn't have been part of the uapi to begin with, and userspace should be able to handle /proc/cmdline of whatever length it turns out to be. I don't see any references to COMMAND_LINE_SIZE anywhere but Linux via a quick Google search, but that's not really enough to consider it unused on my end.

The feedback on the v1 seemed to indicate that COMMAND_LINE_SIZE really shouldn't be part of uapi, so this now touches all the ports. I've tried to split this all out and leave it bisectable, but I haven't tested it all that aggressively.

Changes since v1 <https://lore.kernel.org/all/[email protected]/>:
* Touches every arch.