Skip to content

hw/virtio: Split ioconfig / qmp code from virtio.c

Philippe Mathieu-Daudé qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 4 repliesIn review
  2. v1 RFC10 patches 15 repliesSuperseded

Changes in v2 from the cover letter

- Addressed Richard review comments (restrict scope)

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6hw/virtio: Add missing "hw/core/cpu.h" includehw/virtio/virtio.c+1 -00 replies
2/6hw/virtio: Rename virtio_ss[] -> specific_virtio_ss[]hw/virtio/meson.build+21 -200 replies
3/6hw/virtio: Guard and restrict scope of qmp_virtio_feature_map_t[]hw/virtio/virtio.c+42 -141 reply
4/6hw/virtio: Constify qmp_virtio_feature_map_t[]hw/virtio/virtio.c+17 -171 reply
5/6hw/virtio: Extract config read/write accessors to virtio-config-io.chw/virtio/meson.build hw/virtio/virtio-config-io.c hw/virtio/virtio.c+205 -1900 replies
6/6hw/virtio: Extract QMP related code virtio-qmp.chw/virtio/meson.build hw/virtio/virtio-qmp.c hw/virtio/virtio-qmp.h +1 more+682 -6342 replies

Reviews trailers per patch

2 of 6 patches have a Reviewed-by or Acked-by.

PatchJonah Palmer
1/6
2/6
3/6R-b
4/6R-b
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH-for-8.0 v2 0/6] hw/virtio: Split ioconfig / qmp code from virtio.c

These are the uncontroversial patches of my previous series "hw/virtio: Build most objects as target independent units":
https://lore.kernel.org/qemu-devel/[email protected]/

Housekeeping in hw/virtio/virtio.c:

- Make qmp_virtio_feature_map_t[] arrays static/const
- Extract I/O config accessors
- Extract QMP code

Since v1:
- Addressed Richard review comments (restrict scope)

Philippe Mathieu-Daudé (6):
hw/virtio: Add missing "hw/core/cpu.h" include
hw/virtio: Rename virtio_ss[] -> specific_virtio_ss[] hw/virtio: Guard and restrict scope of qmp_virtio_feature_map_t[] hw/virtio: Constify qmp_virtio_feature_map_t[]
hw/virtio: Extract config read/write accessors to virtio-config-io.c hw/virtio: Extract QMP related code virtio-qmp.c

 hw/virtio/meson.build        |  42 +-
 hw/virtio/virtio-config-io.c | 204 +++++++++
 hw/virtio/virtio-qmp.c       | 659 +++++++++++++++++++++++++++++
 hw/virtio/virtio-qmp.h       |  20 +
 hw/virtio/virtio.c           | 798 +----------------------------------
 5 files changed, 908 insertions(+), 815 deletions(-)
 create mode 100644 hw/virtio/virtio-config-io.c
 create mode 100644 hw/virtio/virtio-qmp.c
 create mode 100644 hw/virtio/virtio-qmp.h
Signature · 1 line
2.38.1