jevents/pmu-events improvements
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest15 patches 14 repliesIn review
- v412 patches 5 repliesSuperseded
- v311 patches 5 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 9 patches | 10 replies | Superseded | |
| v1 | 9 patches | 0 replies | Superseded |
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/15 | perf jevents metric: Correct Function equalitytools/ | +4 | 0 replies | |
| 2/15 | perf jevents metric: Add ability to rewrite metrics in terms of otherstools/ tools/ | +81 | 0 replies | |
| 3/15 | perf jevents: Rewrite metrics in the same file with each othertools/ | +16 | 0 replies | |
| 4/15 | perf pmu-events: Add separate metric from pmu_eventtools/ tools/ tools/ +4 more | +228 | 0 replies | |
| 5/15 | perf pmu-events: Separate the metrics from events for no jeventstools/ tools/ tools/ +3 more | +79 | 0 replies | |
| 6/15 | perf pmu-events: Remove now unused event and metric variablestools/ tools/ tools/ +6 more | +36 | 0 replies | |
| 7/15 | perf stat: Remove evsel metric_name/exprtools/ tools/ tools/ +4 more | +0 | 0 replies | |
| 8/15 | perf jevents: Combine table prefix and suffix writingtools/ | +14 | 0 replies | |
| 9/15 | perf pmu-events: Introduce pmu_metrics_tabletools/ tools/ tools/ +8 more | +78 | 0 replies | |
| 10/15 | perf jevents: Generate metrics and events as separate tablestools/ tools/ | +189 | 3 replies | |
| 11/15 | perf jevents: Add model list optiontools/ tools/ | +16 | 1 reply | |
| 12/15 | perf pmu-events: Fix testing with JEVENTS_ARCH=alltools/ tools/ tools/ | +7 | 1 reply | |
| 13/15 | perf jevents: Correct bad character encodingtools/ | +2 | 0 replies | |
| 14/15 | tools build: Add test echo-cmdtools/ | +1 | 0 replies | |
| 15/15 | perf jevents: Run metric_test.py at compile-timetools/ tools/ | +12 | 2 replies |
Reviews trailers per patch
6 of 15 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Kajol Jain | John Garry |
|---|---|---|
| Series | R-b | |
| 1/15 | R-b | |
| 2/15 | ||
| 3/15 | ||
| 4/15 | R-b | |
| 5/15 | R-b | |
| 6/15 | R-b | |
| 7/15 | R-b | |
| 8/15 | ||
| 9/15 | ||
| 10/15 | ||
| 11/15 | ||
| 12/15 | R-b | |
| 13/15 | ||
| 14/15 | ||
| 15/15 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v5 00/15] jevents/pmu-events improvements
Add an optimization to jevents using the metric code, rewrite metrics
in terms of each other in order to minimize size and improve
readability. For example, on Power8other_stall_cpi is rewritten from:
"PM_CMPLU_STALL / PM_RUN_INST_CMPL - PM_CMPLU_STALL_BRU_CRU / PM_RUN_INST_CMPL - PM_CMPLU_STALL_FXU / PM_RUN_INST_CMPL - PM_CMPLU_STALL_VSU / PM_RUN_INST_CMPL - PM_CMPLU_STALL_LSU / PM_RUN_INST_CMPL - PM_CMPLU_STALL_NTCG_FLUSH / PM_RUN_INST_CMPL - PM_CMPLU_STALL_NO_NTF / PM_RUN_INST_CMPL" to:
"stall_cpi - bru_cru_stall_cpi - fxu_stall_cpi - vsu_stall_cpi - lsu_stall_cpi - ntcg_flush_cpi - no_ntf_stall_cpi"
Which more closely matches the definition on Power9.
A limitation of the substitutions are that they depend on strict equality and the shape of the tree. This means that for "a + b + c" then a substitution of "a + b" will succeed while "b + c" will fail (the LHS for "+ c" is "a + b" not just "b").
Separate out the events and metrics in the pmu-events tables saving 14.8% in the table size while making it that metrics no longer need to iterate over all events and vice versa. These changes remove evsel's direct metric support as the pmu_event no longer has a metric to populate it. This is a minor issue as the code wasn't working properly, metrics for this are rare and can still be properly ran using '-M'.
Add an ability to just build certain models into the jevents generated pmu-metrics.c code. This functionality is appropriate for operating systems like ChromeOS, that aim to minimize binary size and know all the target CPU models.
v5. s/list/List/ in a type annotation to fix Python 3.6 as reported by
John Garry <[email protected]>. Fix a bug in metric_test.py where a bad character was imported. To avoid similar regressions, run metric_test.py before generating pmu-events.c.
v4. Better support the implementor/model style --model argument for
jevents.py. Add #slots test fix. On some patches add reviewed-by John Garry <[email protected]> and Kajol Jain<[email protected]>.
v3. Rebase an incorporate review comments from John Garry
<[email protected]>, in particular breaking apart patch 4 into 3 patches. The no jevents breakage and then later fix is avoided in this series too.
v2. Rebase. Modify the code that skips rewriting a metric with the
same name with itself, to make the name check case insensitive.
Ian Rogers (15):
perf jevents metric: Correct Function equality
perf jevents metric: Add ability to rewrite metrics in terms of others perf jevents: Rewrite metrics in the same file with each other perf pmu-events: Add separate metric from pmu_event
perf pmu-events: Separate the metrics from events for no jevents perf pmu-events: Remove now unused event and metric variables perf stat: Remove evsel metric_name/expr
perf jevents: Combine table prefix and suffix writing
perf pmu-events: Introduce pmu_metrics_table
perf jevents: Generate metrics and events as separate tables perf jevents: Add model list option
perf pmu-events: Fix testing with JEVENTS_ARCH=all
perf jevents: Correct bad character encoding
tools build: Add test echo-cmd
perf jevents: Run metric_test.py at compile-time
tools/build/Makefile.build | 1 + tools/perf/arch/arm64/util/pmu.c | 11 +- tools/perf/arch/powerpc/util/header.c | 4 +- tools/perf/builtin-list.c | 20 +- tools/perf/builtin-stat.c | 1 - tools/perf/pmu-events/Build | 16 +- tools/perf/pmu-events/empty-pmu-events.c | 108 ++++++- tools/perf/pmu-events/jevents.py | 357 +++++++++++++++++++---- tools/perf/pmu-events/metric.py | 79 ++++- tools/perf/pmu-events/metric_test.py | 15 +- tools/perf/pmu-events/pmu-events.h | 26 +- tools/perf/tests/expand-cgroup.c | 4 +- tools/perf/tests/parse-metric.c | 4 +- tools/perf/tests/pmu-events.c | 69 ++--- tools/perf/util/cgroup.c | 1 - tools/perf/util/evsel.c | 2 - tools/perf/util/evsel.h | 2 - tools/perf/util/expr.h | 1 + tools/perf/util/expr.l | 8 +- tools/perf/util/metricgroup.c | 207 +++++++------ tools/perf/util/metricgroup.h | 4 +- tools/perf/util/parse-events.c | 2 - tools/perf/util/pmu.c | 44 +-- tools/perf/util/pmu.h | 10 +- tools/perf/util/print-events.c | 32 +- tools/perf/util/print-events.h | 3 +- tools/perf/util/python.c | 7 - tools/perf/util/stat-shadow.c | 112 ------- tools/perf/util/stat.h | 1 - 29 files changed, 681 insertions(+), 470 deletions(-) mode change 100644 => 100755 tools/perf/pmu-events/metric_test.py
Signature · 1 line
2.39.1.456.gfc5497dd1b-goog