Standardize telemetry int types
Status from this message: Applied, thanks.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest9 patches 3 repliesApplied
- v29 patches 0 repliesSuperseded
- v1 RFC7 patches 20 repliesSuperseded
Changes in v3 from the cover letter
- fix build issues due to missing a driver code change
- fix spelling issue flagged by checkpatch
Patches in v3 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | telemetry: remove RTE prefix from internal enum valueslib/ lib/ lib/ +1 more | +46 | 0 replies | |
| 2/9 | telemetry: make array initialization more robustlib/ | +4 | 0 replies | |
| 3/9 | telemetry: rename unsigned 64-bit enum value to uintapp/ drivers/ drivers/ +7 more | +21 | 0 replies | |
| 4/9 | telemetry: add uint type as alias for u64lib/ lib/ lib/ +2 more | +74 | 0 replies | |
| 5/9 | global: rename telemetry functions to newer versionsapp/ drivers/ drivers/ +13 more | +130 | 0 replies | |
| 6/9 | telemetry: mark old names of renamed fns as deprecateddoc/ lib/ lib/ | +12 | 0 replies | |
| 7/9 | telemetry: update json functions to use int/uint in namesapp/ lib/ lib/ | +16 | 0 replies | |
| 8/9 | telemetry: make internal int representation 64-bitslib/ | +1 | 0 replies | |
| 9/9 | telemetry: change public API to use 64-bit signed valueslib/ lib/ lib/ +2 more | +45 | 1 reply |
Reviews trailers per patch
7 of 9 patches have a Reviewed-by or Acked-by.
| Patch | Morten Brørup | Tyler Retzlaff | Ciara Power |
|---|---|---|---|
| Series | Series-Acked-by | ||
| 1/9 | A-b | A-b | |
| 2/9 | A-b | A-b | |
| 3/9 | A-b | A-b | |
| 4/9 | A-b | A-b | |
| 5/9 | |||
| 6/9 | |||
| 7/9 | A-b | A-b | |
| 8/9 | A-b | A-b | |
| 9/9 | A-b | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v3 0/9] Standardize telemetry int types
Rather than having 64-bit unsigned types and 32-bit signed types supported by the telemetry lib, we should support 64-bit values for both types. On the naming side, since both are 64-bit, we should no longer call the unsigned value u64 - "uint" is better.
This patchset implements these changes as far as is possible while still keeping API and ABI compatibility.
* Internal structures and functions are updated to use 64-bit ints
* Internal functions are renamed from u64 to uint
* Public enum values are renamed from u64 to uint, and a macro is added to ensure that older code still compiles
* The public add_*_int functions are changed to take a 64-bit value rather than a 32-bit one. Since this would be an ABI break, we use function versioning to ensure older code still calls into a wrapper function which takes a 32-bit value.
The patchset also contains a couple of other small cleanups to the telemetry code that were seen in passing when making these changes - removing RTE_ prefix on internal enums, and simplifying the init of the the array of data types.
NOTE: the renaming of the u64 functions to uint is split across 3 patches in this set - patches 4,5 and 6. This is to make it easier to review and to avoid warnings about new functions not being marked initially as experimental. Some/all of these 3 can be combined on merge if so desired.
V3:
- fix build issues due to missing a driver code change
- fix spelling issue flagged by checkpatch
V2:
- added additional patches to replace the old function calls within DPDK code, something missed in RFC version
- added new patch to make the renamed/new functions immediately public allowing us to mark the original named versions as deprecated
- re-ordered patches within the sit, so the extra cleanup changes come first
Bruce Richardson (9):
telemetry: remove RTE prefix from internal enum values
telemetry: make array initialization more robust
telemetry: rename unsigned 64-bit enum value to uint
telemetry: add uint type as alias for u64
global: rename telemetry functions to newer versions
telemetry: mark old names of renamed fns as deprecated
telemetry: update json functions to use int/uint in names
telemetry: make internal int representation 64-bits
telemetry: change public API to use 64-bit signed values
app/test/test_telemetry_data.c | 22 ++--- app/test/test_telemetry_json.c | 9 +- doc/guides/rel_notes/deprecation.rst | 5 ++ drivers/common/cnxk/roc_platform.h | 4 +- drivers/net/cnxk/cnxk_ethdev_sec_telemetry.c | 24 ++--- drivers/net/cnxk/cnxk_ethdev_telemetry.c | 6 +- examples/ipsec-secgw/ipsec-secgw.c | 72 +++++++-------- examples/l3fwd-power/main.c | 4 +- lib/cryptodev/rte_cryptodev.c | 6 +- lib/dmadev/rte_dmadev.c | 2 +- lib/eal/common/eal_common_memory.c | 19 ++-- lib/ethdev/rte_ethdev.c | 12 +-- lib/ethdev/sff_telemetry.c | 2 +- lib/eventdev/rte_event_eth_rx_adapter.c | 22 ++--- lib/eventdev/rte_event_timer_adapter.c | 38 ++++---- lib/eventdev/rte_eventdev.c | 5 +- lib/ipsec/ipsec_telemetry.c | 33 +++---- lib/rawdev/rte_rawdev.c | 4 +- lib/security/rte_security.c | 8 +- lib/telemetry/meson.build | 1 + lib/telemetry/rte_telemetry.h | 51 +++++++++-- lib/telemetry/telemetry.c | 56 ++++++------ lib/telemetry/telemetry_data.c | 95 ++++++++++++++------ lib/telemetry/telemetry_data.h | 24 +++-- lib/telemetry/telemetry_json.h | 16 ++-- lib/telemetry/version.map | 9 ++ 26 files changed, 325 insertions(+), 224 deletions(-)
--
2.37.2