Skip to content

RFC devlink: code split and structured instance walk

Jakub Kicinski netdev netfilter-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest15 patches 26 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15devlink: move code to a dedicated directorynet/Makefile net/core/Makefile net/devlink/Makefile +1 more+4 -110 replies
2/15devlink: split out core codenet/devlink/Makefile net/devlink/basic.c net/devlink/core.c +1 more+476 -4340 replies
3/15devlink: split out netlink codenet/devlink/Makefile net/devlink/basic.c net/devlink/devl_internal.h +1 more+235 -2053 replies
4/15devlink: protect devlink dump by the instance locknet/devlink/basic.c+3 -02 replies
5/15netlink: add macro for checking dump ctx sizeinclude/linux/netlink.h net/netfilter/nf_conntrack_netlink.c+5 -10 replies
6/15devlink: use an explicit structure for dump contextnet/devlink/basic.c net/devlink/devl_internal.h+81 -403 replies
7/15devlink: remove start variables from dumpsnet/devlink/basic.c+19 -360 replies
8/15devlink: drop the filter argument from devlinks_xa_find_getnet/devlink/core.c net/devlink/devl_internal.h+10 -171 reply
9/15devlink: health: combine loops in dumpnet/devlink/basic.c+0 -30 replies
10/15devlink: restart dump based on devlink instance ids (simple)net/devlink/basic.c net/devlink/core.c net/devlink/devl_internal.h+23 -291 reply
11/15devlink: restart dump based on devlink instance ids (nested)net/devlink/basic.c net/devlink/devl_internal.h+49 -460 replies
12/15devlink: restart dump based on devlink instance ids (function)net/devlink/basic.c+21 -200 replies
13/15devlink: uniformly take the devlink instance lock in the dump loopnet/devlink/basic.c+6 -70 replies
14/15devlink: add by-instance dump infranet/devlink/basic.c net/devlink/devl_internal.h net/devlink/netlink.c+67 -315 replies
15/15devlink: convert remaining dumps to the by-instance schemenet/devlink/basic.c net/devlink/devl_internal.h net/devlink/netlink.c+320 -3940 replies

Reviews trailers per patch

None of the 15 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJacob Keller
SeriesR-b
1/15
2/15
3/15
4/15
5/15
6/15
7/15
8/15
9/15
10/15
11/15
12/15
13/15
14/15
15/15

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC net-next 00/15] devlink: code split and structured instance walk

Hi!

I started working on the refcounting / registration changes and (as is usual in our profession) I quickly veered off into refactoring / paying technical debt. I hope this is not too controversial.

===

Split devlink.c into a handful of files, trying to keep the "core" code away from all the command-specific implementations. The core code has been quite scattered before. Going forward we can consider using a source file per-subobject, I think that it's quite beneficial to newcomers (based on relative ease with which folks contribute to ethtool vs devlink). But this series doesn't split everything out, yet - partially due to backporting concerns, but mostly due to lack of time.

Introduce a context structure for dumps, and use it to store the devlink instance ID of the last dumped devlink instance. This means we don't have to restart the walk from 0 each time.

Finally - introduce a "structured walk". A centralized dump handler in devlink/netlink.c which walks the devlink instances, deals with refcounting/locking, simplifying the per-object implementations quite a bit.

Jakub Kicinski (15):
devlink: move code to a dedicated directory
devlink: split out core code
devlink: split out netlink code
devlink: protect devlink dump by the instance lock
netlink: add macro for checking dump ctx size
devlink: use an explicit structure for dump context
devlink: remove start variables from dumps
devlink: drop the filter argument from devlinks_xa_find_get
devlink: health: combine loops in dump
devlink: restart dump based on devlink instance ids (simple)
devlink: restart dump based on devlink instance ids (nested)
devlink: restart dump based on devlink instance ids (function)
devlink: uniformly take the devlink instance lock in the dump loop
devlink: add by-instance dump infra
devlink: convert remaining dumps to the by-instance scheme

 include/linux/netlink.h                 |    4 +
 net/Makefile                            |    1 +
 net/core/Makefile                       |    1 -
 net/devlink/Makefile                    |    3 +
 net/{core/devlink.c => devlink/basic.c} | 1457 ++++++-----------------
 net/devlink/core.c                      |  345 ++++++
 net/devlink/devl_internal.h             |  205 ++++
 net/devlink/netlink.c                   |  241 ++++
 net/netfilter/nf_conntrack_netlink.c    |    2 +-
 9 files changed, 1157 insertions(+), 1102 deletions(-)
 create mode 100644 net/devlink/Makefile
 rename net/{core/devlink.c => devlink/basic.c} (90%)
 create mode 100644 net/devlink/core.c
 create mode 100644 net/devlink/devl_internal.h
 create mode 100644 net/devlink/netlink.c
Signature · 1 line
2.38.1