Skip to content

i915/i915_hwmon: General verification of hwmon attributes

Ashutosh Dixit igt-dev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3lib/igt_sysfs: Generic verification of writable sysfs attributeslib/igt_sysfs.c lib/igt_sysfs.h+99 -02 replies
2/3i915/i915_hwmon: General verification of hwmon attributestests/i915/i915_hwmon.c tests/meson.build+89 -01 reply
3/3HAX: Add i915_hwmon* to fast-feedback.testlisttests/intel-ci/fast-feedback.testlist+2 -00 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchRiana Tauro
1/3R-b
2/3R-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [igt-dev] [PATCH i-g-t 0/3] i915/i915_hwmon: General verification of hwmon attributes

Ensure we can read all hwmon attributes. For writable attributes, also ensure the read value approximately matches the written value, taking the clamping of writes into account.

v2: Added new patch "lib/igt_sysfs: Make it easier to extend verification
of clamped sysfs attr". No changes to previous patches.
v3: Identical to v2, failed to copy reviewers
v4: Drop the concept of a 'clamped' sysfs attribute, it is not
necessary. All we need is a writable attribute for which the read values will match the written values for a few points across the range of all possible values.
v5: Dropped function rw_attr_reverify_points since it was repeating the
verification already done during the sweep so has limited utility. This results in simplifying the code even more.

Ashutosh Dixit (3):
lib/igt_sysfs: Generic verification of writable sysfs attributes i915/i915_hwmon: General verification of hwmon attributes
HAX: Add i915_hwmon* to fast-feedback.testlist

 lib/igt_sysfs.c                       | 79 ++++++++++++++++++++++++
 lib/igt_sysfs.h                       | 20 ++++++
 tests/i915/i915_hwmon.c               | 88 +++++++++++++++++++++++++++
 tests/intel-ci/fast-feedback.testlist |  2 +
 tests/meson.build                     |  1 +
 5 files changed, 190 insertions(+)
 create mode 100644 tests/i915/i915_hwmon.c
Signature · 1 line
2.38.0