Make rule parsing strict
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest4 patches 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | nft: Parse icmp header matchesiptables/ iptables/ | +77 | 0 replies | |
| 2/4 | arptables: Check the mandatory ar_pln matchiptables/ | +6 | 0 replies | |
| 3/4 | nft: Increase rule parser strictnessiptables/ iptables/ iptables/ +2 more | +37 | 0 replies | |
| 4/4 | nft: Make rule parsing errors fataliptables/ | +3 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [iptables PATCH 0/4] Make rule parsing strict
Abort the program when encountering rules with unsupported matches.
While nft_is_table_compatible() tries to catch this situation, it boils down to merely accepting or rejecting expressions based on type. Yet these may still be used in incompatible ways.
Patch 1 fixes for payload matches on ICMP(v6) headers and is almost independent of the rest.
Patch 2 prepares arptables rule parsing for the error message added by patch 3.
Patch 3 makes various situations complain by emitting error messages. It was compiled after reviewing all callees of rule_to_cs callback for unhandled unexpected input.
Patch 5 then finally does it's thing.
Phil Sutter (4):
nft: Parse icmp header matches
arptables: Check the mandatory ar_pln match
nft: Increase rule parser strictness
nft: Make rule parsing errors fatal
iptables/nft-arp.c | 9 +- iptables/nft-bridge.c | 4 + iptables/nft-ipv4.c | 4 +- iptables/nft-ipv6.c | 4 +- iptables/nft-shared.c | 113 ++++++++++++++++-- .../nft-only/0010-iptables-nft-save.txt | 6 +- 6 files changed, 123 insertions(+), 17 deletions(-)
Signature · 1 line
2.38.0