Skip to content

hw: make TCO watchdog actually work by default for Q35

Daniel P. Berrangé qemu-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 0 repliesNew

Changed in v2 from the cover letter

- Added extra patch to honour the 'enable_tco' property

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5hw/acpi: add trace events for TCO watchdog register accesshw/acpi/tco.c hw/acpi/trace-events+30 -130 replies
2/5hw/isa: add trace events for ICH9 LPC chip config accesshw/isa/lpc_ich9.c hw/isa/trace-events+7 -00 replies
3/5hw/watchdog: add trace events for watchdog action handlinghw/watchdog/trace-events hw/watchdog/watchdog.c+8 -00 replies
4/5hw/isa: enable TCO watchdog reboot pin strap by defaulthw/i386/pc.c hw/isa/lpc_ich9.c tests/qtest/tco-test.c+5 -30 replies
5/5ich9: honour 'enable_tco' propertyhw/acpi/ich9.c+4 -20 replies

Reviews trailers per patch

4 of 5 patches have a Reviewed-by or Acked-by.

PatchRichard W.M. JonesPhilippe Mathieu-Daudé
1/5R-b
2/5R-b
3/5R-b R-b
4/5R-b
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] hw: make TCO watchdog actually work by default for Q35

The TCO watchdog is unconditionally integrated into the Q35 machine type by default, but at the same time is unconditionally disabled from firing by a host config option that overrides guest OS attempts to enable it. People have to know to set a magic -global to make it non-broken

IOW we're exposing a broken watchdog by default to all Q35 machines, but which to the guest OS & its apps looks fully functional :-(

This behaviour was set in response to feedback from Michael:

https://lists.gnu.org/archive/html/qemu-devel/2015-06/msg07128.html

"I think sample high is a safer default."

but as explained in the commit message in the last patch, I think the watchdog defaults were already safe without that pin strap setting. The guest OS needs to take explicit action to clear the guest visible 'no reboot' flag, and so we don't need a second guest hidden 'no reboot' flag to override that choice IMHO. Am I missing something ?

NB, I'm toggling this for 7.2 machine type since that's the current git latest machine. Obviously this will need to be changed once the 8.0 machine types are merged.

Changed in v2:

- Added extra patch to honour the 'enable_tco' property

Daniel P. Berrangé (5):
hw/acpi: add trace events for TCO watchdog register access hw/isa: add trace events for ICH9 LPC chip config access hw/watchdog: add trace events for watchdog action handling hw/isa: enable TCO watchdog reboot pin strap by default
ich9: honour 'enable_tco' property

 hw/acpi/ich9.c           |  6 ++++--
 hw/acpi/tco.c            | 41 +++++++++++++++++++++++++++-------------
 hw/acpi/trace-events     |  2 ++
 hw/i386/pc.c             |  4 +++-
 hw/isa/lpc_ich9.c        |  5 ++++-
 hw/isa/trace-events      |  4 ++++
 hw/watchdog/trace-events |  4 ++++
 hw/watchdog/watchdog.c   |  4 ++++
 tests/qtest/tco-test.c   |  2 +-
 9 files changed, 54 insertions(+), 18 deletions(-)
Signature · 1 line
2.38.1