Skip to content

RFC devlink: remove the wait-for-references on unregister

Jakub Kicinski netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest10 patches 39 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10devlink: bump the instance index directly when iteratingnet/devlink/core.c net/devlink/devl_internal.h+13 -355 replies
2/10devlink: update the code in netns move to latest helpersnet/devlink/core.c+4 -31 reply
3/10devlink: protect devlink->dev by the instance locknet/devlink/basic.c net/devlink/devl_internal.h net/devlink/netlink.c+11 -80 replies
4/10devlink: always check if the devlink instance is registeredinclude/net/devlink.h net/devlink/basic.c net/devlink/core.c +1 more+59 -1214 replies
5/10devlink: remove the registration guarantee of referencesinclude/net/devlink.h net/devlink/core.c net/devlink/devl_internal.h+30 -387 replies
6/10devlink: don't require setting features before registrationnet/devlink/core.c+0 -24 replies
7/10netdevsim: rename a labeldrivers/net/netdevsim/dev.c+2 -21 reply
8/10netdevsim: move devlink registration under the instance lockdrivers/net/netdevsim/dev.c+8 -30 replies
9/10devlink: allow registering parameters after the instancenet/devlink/basic.c+11 -110 replies
10/10netdevsim: register devlink instance before sub-objectsdrivers/net/netdevsim/dev.c+9 -94 replies

Reviews trailers per patch

3 of 10 patches have a Reviewed-by or Acked-by.

PatchJacob KellerJiri Pirko
1/10
2/10R-b
3/10
4/10
5/10R-b
6/10
7/10R-b
8/10
9/10
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC net-next 00/10] devlink: remove the wait-for-references on unregister

This set is on top of the previous RFC.

Move the registration and unregistration of the devlink instances under their instance locks. Don't perform the netdev-style wait for all references when unregistering the instance.

Jakub Kicinski (10):
devlink: bump the instance index directly when iterating
devlink: update the code in netns move to latest helpers
devlink: protect devlink->dev by the instance lock
devlink: always check if the devlink instance is registered
devlink: remove the registration guarantee of references
devlink: don't require setting features before registration
netdevsim: rename a label
netdevsim: move devlink registration under the instance lock
devlink: allow registering parameters after the instance
netdevsim: register devlink instance before sub-objects

 drivers/net/netdevsim/dev.c |  15 +++--
 include/net/devlink.h       |   3 +
 net/devlink/basic.c         |  64 ++++++++++++------
 net/devlink/core.c          | 127 +++++++++++++++++-------------------
 net/devlink/devl_internal.h |  20 ++----
 net/devlink/netlink.c       |  19 ++++--
 6 files changed, 136 insertions(+), 112 deletions(-)
Signature · 1 line
2.38.1