Skip to content

RFC Add vfio_device cdev for iommufd support

Yi Liu kvm 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest12 patches 31 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12vfio: Allocate per device file structuredrivers/vfio/group.c drivers/vfio/vfio.h drivers/vfio/vfio_main.c+42 -82 replies
2/12vfio: Refine vfio file kAPIsdrivers/vfio/group.c drivers/vfio/pci/vfio_pci_core.c drivers/vfio/vfio.h +3 more+92 -640 replies
3/12vfio: Accept vfio device file in the driver facing kAPIdrivers/vfio/vfio.h drivers/vfio/vfio_main.c+61 -44 replies
4/12kvm/vfio: Rename kvm_vfio_group to prepare for accepting vfio device fdvirt/kvm/vfio.c+58 -570 replies
5/12kvm/vfio: Accept vfio device file from userspaceDocumentation/virt/kvm/devices/vfio.rst include/uapi/linux/kvm.h virt/kvm/vfio.c+42 -317 replies
6/12vfio: Pass struct vfio_device_file * to vfio_device_open/close()drivers/vfio/group.c drivers/vfio/vfio.h drivers/vfio/vfio_main.c+54 -302 replies
7/12vfio: Block device access via device fd until device is openeddrivers/vfio/vfio.h drivers/vfio/vfio_main.c+35 -02 replies
8/12vfio: Add infrastructure for bind_iommufd and attachdrivers/vfio/group.c drivers/vfio/iommufd.c drivers/vfio/vfio.h +1 more+88 -283 replies
9/12vfio: Make vfio_device_open() exclusive between group path and device cdev pathdrivers/vfio/group.c drivers/vfio/vfio.h drivers/vfio/vfio_main.c +1 more+29 -51 reply
10/12vfio: Add cdev for vfio_devicedrivers/vfio/vfio_main.c include/linux/vfio.h+99 -91 reply
11/12vfio: Add ioctls for device cdev iommufddrivers/vfio/vfio_main.c include/uapi/linux/iommufd.h include/uapi/linux/vfio.h+206 -57 replies
12/12vfio: Compile group optionallydrivers/vfio/Kconfig drivers/vfio/Makefile drivers/vfio/vfio.h +1 more+99 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC 00/12] Add vfio_device cdev for iommufd support

Existing VFIO provides group-centric user APIs for userspace. Userspace opens the /dev/vfio/$group_id first before getting device fd and hence getting access to device. This is not the desired model for iommufd. Per the conclusion of community discussion[1], iommufd provides device-centric kAPIs and requires its consumer (like VFIO) to be device-centric user APIs. Such user APIs are used to associate device with iommufd and also the I/O address spaces managed by the iommufd.

This series first introduces a per device file structure to be prepared for further enhancement and refactors the kvm-vfio code to be prepared for accepting device file from userspace. Then refactors the vfio to be able to handle iommufd binding. This refactor includes the mechanism of blocking device access before iommufd bind, making vfio_device_open() be exclusive between the group path and the cdev path. Eventually, adds the cdev support for vfio device, and makes group infrastructure optional as it is not needed when vfio device cdev is compiled.

This is also a base for further support iommu nesting for vfio device[2].

The complete code can be found in below branch, simple test done with the legacy group path and the cdev path. Draft QEMU branch can be found at[3]

https://github.com/yiliu1765/iommufd/tree/vfio_device_cdev_rfcv1
(config CONFIG_IOMMUFD=y)

[1] https://lore.kernel.org/kvm/BN9PR11MB5433B1E4AE5B0480369F97178C189@BN9PR11MB5433.namprd11.prod.outlook.com/
[2] https://github.com/yiliu1765/iommufd/tree/wip/iommufd-v6.1-rc3-nesting
[3] https://github.com/yiliu1765/qemu/tree/wip/qemu-iommufd-6.1-rc3

Regards,
Yi Liu

Yi Liu (12):
vfio: Allocate per device file structure
vfio: Refine vfio file kAPIs
vfio: Accept vfio device file in the driver facing kAPI kvm/vfio: Rename kvm_vfio_group to prepare for accepting vfio device
fd
kvm/vfio: Accept vfio device file from userspace
vfio: Pass struct vfio_device_file * to vfio_device_open/close()
vfio: Block device access via device fd until device is opened
vfio: Add infrastructure for bind_iommufd and attach
vfio: Make vfio_device_open() exclusive between group path and device
cdev path
vfio: Add cdev for vfio_device
vfio: Add ioctls for device cdev iommufd
vfio: Compile group optionally

 Documentation/virt/kvm/devices/vfio.rst |  32 +-
 drivers/vfio/Kconfig                    |  17 +
 drivers/vfio/Makefile                   |   3 +-
 drivers/vfio/group.c                    | 131 +++----
 drivers/vfio/iommufd.c                  |  79 +++-
 drivers/vfio/pci/vfio_pci_core.c        |   4 +-
 drivers/vfio/vfio.h                     | 108 +++++-
 drivers/vfio/vfio_main.c                | 492 ++++++++++++++++++++++--
 include/linux/vfio.h                    |  21 +-
 include/uapi/linux/iommufd.h            |   2 +
 include/uapi/linux/kvm.h                |  23 +-
 include/uapi/linux/vfio.h               |  64 +++
 virt/kvm/vfio.c                         | 143 +++----
 13 files changed, 891 insertions(+), 228 deletions(-)
Signature · 1 line
2.34.1