Skip to content

tracing: Add a way to filter function addresses to function names

Steven Rostedt linux-kselftest linux-trace-kernel lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2tracing: Add a way to filter function addresses to function namesDocumentation/trace/events.rst kernel/trace/trace_events.c kernel/trace/trace_events_filter.c+105 -21 reply
2/2tracing/selftests: Add test for event filtering on function nametools/testing/selftests/ftrace/test.d/filter/event-filter-function.tc+58 -05 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchRoss ZwislerShuah Khan
1/2R-b
2/2R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] tracing: Add a way to filter function addresses to function names

There's been several times where an event records a function address in its field and I needed to filter on that address for a specific function name. It required looking up the function in kallsyms, finding its size, and doing a compare of "field >= function_start && field < function_end".

But this would change from boot to boot and is unreliable in scripts. Also, it is useful to have this at boot up, where the addresses will not be known. For example, on the boot command line:

trace_trigger="initcall_finish.traceoff if func.function == acpi_init"

To implement this, add a ".function" prefix, that will check that the field is of size long, and the only operations allowed (so far) are "==" and "!=".

Changes since v1: https://lore.kernel.org/linux-trace-kernel/[email protected]/

- Fix commit log "initcall_finish.function" to "func.function" (Ross Zwisler)

- Fixed processing of address (Ross Zwisler)

- Added selftest (Masami Hiramatsu)

- Just use "trigger" instead of "strsep(&trigger, "")" (Zheng Yejian)

Steven Rostedt (Google) (2):
tracing: Add a way to filter function addresses to function names tracing/selftests: Add test for event filtering on function name

----

 Documentation/trace/events.rst                     | 12 +++
 kernel/trace/trace_events.c                        |  2 +-
 kernel/trace/trace_events_filter.c                 | 93 +++++++++++++++++++++-
 .../ftrace/test.d/filter/event-filter-function.tc  | 58 ++++++++++++++
 4 files changed, 163 insertions(+), 2 deletions(-)
 create mode 100644 tools/testing/selftests/ftrace/test.d/filter/event-filter-function.tc