Skip to content

Compiler warning fixes for libvhost-user,libvduse

Marcel Holtmann qemu-devel 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest12 patches 5 repliesIn review
  2. v310 patches 4 repliesSuperseded
  3. v210 patches 6 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v13 patches0 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12libvhost-user: Provide _GNU_SOURCE when compiling outside of QEMUsubprojects/libvhost-user/libvhost-user.c+4 -00 replies
2/12libvhost-user: Replace typeof with __typeof__subprojects/libvhost-user/libvhost-user.c+2 -20 replies
3/12libvhost-user: Cast rc variable to avoid compiler warningsubprojects/libvhost-user/libvhost-user.c+1 -10 replies
4/12libvhost-user: Use unsigned int i for some for-loop iterationssubprojects/libvhost-user/libvhost-user.c+7 -70 replies
5/12libvhost-user: Declare uffdio_register early to make it C90 compliantsubprojects/libvhost-user/libvhost-user.c+3 -10 replies
6/12libvhost-user: Change dev->postcopy_ufd assignment to make it C90 compliantsubprojects/libvhost-user/libvhost-user.c+2 -10 replies
7/12libvduse: Provide _GNU_SOURCE when compiling outside of QEMUsubprojects/libvduse/libvduse.c+4 -00 replies
8/12libvduse: Switch to unsigned int for inuse field in struct VduseVirtqsubprojects/libvduse/libvduse.c+1 -10 replies
9/12libvduse: Fix assignment in vring_set_avail_eventsubprojects/libvduse/libvduse.c+2 -10 replies
10/12libvhost-user: Fix assignment in vring_set_avail_eventsubprojects/libvhost-user/libvhost-user.c+2 -30 replies
11/12libvhost-user: Add extra compiler warningssubprojects/libvhost-user/meson.build+7 -10 replies
12/12libvduse: Add extra compiler warningssubprojects/libvduse/meson.build+7 -10 replies

Reviews trailers per patch

4 of 12 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchXie YongjiPhilippe Mathieu-DaudéMichael S. Tsirkin
SeriesR-b
1/12
2/12R-b
3/12
4/12
5/12R-b
6/12R-b
7/12
8/12R-b
9/12
10/12
11/12
12/12

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v4 thread

Cover letter [PATCH v4 00/12] Compiler warning fixes for libvhost-user,libvduse

The libvhost-user and libvduse libraries are also useful for external usage outside of QEMU and thus it would be nice if their files could be just copied and used. However due to different compiler settings, a lot of manual fixups are needed. This is the first attempt at some obvious fixes that can be done without any harm to the code and its readability.

Marcel Holtmann (12):
libvhost-user: Provide _GNU_SOURCE when compiling outside of QEMU
libvhost-user: Replace typeof with __typeof__
libvhost-user: Cast rc variable to avoid compiler warning
libvhost-user: Use unsigned int i for some for-loop iterations
libvhost-user: Declare uffdio_register early to make it C90 compliant
libvhost-user: Change dev->postcopy_ufd assignment to make it C90 compliant
libvduse: Provide _GNU_SOURCE when compiling outside of QEMU
libvduse: Switch to unsigned int for inuse field in struct VduseVirtq
libvduse: Fix assignment in vring_set_avail_event
libvhost-user: Fix assignment in vring_set_avail_event
libvhost-user: Add extra compiler warnings
libvduse: Add extra compiler warnings

 subprojects/libvduse/libvduse.c           |  9 ++++--
 subprojects/libvduse/meson.build          |  8 ++++-
 subprojects/libvhost-user/libvhost-user.c | 36 +++++++++++++----------
 subprojects/libvhost-user/meson.build     |  8 ++++-
 4 files changed, 42 insertions(+), 19 deletions(-)
Signature · 1 line
2.38.1