Skip to content

Make the irqchip immutable

Cixi Geng linux-gpio lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest3 patches 1 replyIn review
  2. v33 patches 3 repliesSuperseded
  3. v23 patches 0 repliesSuperseded

Changes in v4 from the cover letter

Change the irq name.
Keep the same coding style by using offset for irqd_to_hwirq(data) Add Reviewed-by tag.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3gpio: eic-sprd: Make the irqchip immutabledrivers/gpio/gpio-eic-sprd.c+14 -90 replies
2/3gpio: gpio-pmic-eic-sprd: Make the irqchip immutabledrivers/gpio/gpio-pmic-eic-sprd.c+18 -110 replies
3/3gpio: gpio-sprd: Make the irqchip immutabledrivers/gpio/gpio-sprd.c+6 -30 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchBaolin Wang
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH V4 0/3] Make the irqchip immutable

From: Cixi Geng <[email protected]>

Kernel warns about mutable irq_chips:
"not an immutable chip, please consider fixing!"

Make the struct irq_chip const, flag it as IRQCHIP_IMMUTABLE, add the new helper functions, and call the appropriate gpiolib functions.

v2 changes:
Split the patch by each driver. and other comment by baolin in[1]

v3 changes:
Fix cocci warnings test by lkp[2].

v4 changes:
Change the irq name.
Keep the same coding style by using offset for irqd_to_hwirq(data) Add Reviewed-by tag.

[1]:https://lore.kernel.org/all/[email protected]/ [2]:https://lore.kernel.org/all/[email protected]/

Cixi Geng (3):
gpio: eic-sprd: Make the irqchip immutable
gpio: gpio-pmic-eic-sprd: Make the irqchip immutable
gpio: gpio-sprd: Make the irqchip immutable

 drivers/gpio/gpio-eic-sprd.c      | 23 ++++++++++++++---------
 drivers/gpio/gpio-pmic-eic-sprd.c | 29 ++++++++++++++++++-----------
 drivers/gpio/gpio-sprd.c          |  9 ++++++---
 3 files changed, 38 insertions(+), 23 deletions(-)

base-commit: 1b929c02afd37871d5afb9d498426f83432e71c2

Signature · 1 line
2.34.1