Skip to content

net/ncsi: Add NC-SI 1.2 Get MC MAC Address command

Peter Delevoryas lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3net/ncsi: Simplify Kconfig/dts control flownet/ncsi/ncsi-manage.c+3 -170 replies
2/3net/ncsi: Fix netlink major/minor version numbersnet/ncsi/internal.h net/ncsi/ncsi-netlink.c net/ncsi/ncsi-pkt.h +1 more+36 -80 replies
3/3net/ncsi: Add NC-SI 1.2 Get MC MAC Address commandnet/ncsi/ncsi-cmd.c net/ncsi/ncsi-manage.c net/ncsi/ncsi-pkt.h +1 more+63 -42 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] net/ncsi: Add NC-SI 1.2 Get MC MAC Address command

NC-SI 1.2 isn't officially released yet, but the DMTF takes way too long to finalize stuff, and there's hardware out there that actually supports this command (Just the Broadcom 200G NIC afaik).

The work in progress spec document is here:

https://www.dmtf.org/sites/default/files/standards/documents/DSP0222_1.2WIP90_0.pdf

The command code is 0x58, the command has no data, and the response returns a variable-length array of MAC addresses for the BMC.

I've tested this out using QEMU emulation (I added the Mellanox OEM Get MAC Address command to libslirp a while ago [1], although the QEMU code to use it is still not in upstream QEMU [2] [3]. I worked on some more emulation code for this as well), and on the new Broadcom 200G NIC.

The Nvidia ConnectX-7 NIC doesn't support NC-SI 1.2 yet afaik. Neither do older versions in newer firmware, they all just report NC-SI 1.1.

Let me know what I can do to change this patch to be more suitable for upstreaming, I'm happy to work on it more!

Thanks,
Peter

[1] https://gitlab.freedesktop.org/slirp/libslirp/-/blob/0dd7f05095c0a77d9d2ec4764e8617192b4fa6ec/src/ncsi.c#L59
[2] https://github.com/facebook/openbmc/blob/a33dbcc25759f00baf113fd497c8d9db60eeed9e/common/recipes-devtools/qemu/qemu/0003-slirp-Add-mfr-id-to-netdev-options.patch
[3] https://github.com/facebook/openbmc/blob/a33dbcc25759f00baf113fd497c8d9db60eeed9e/common/recipes-devtools/qemu/qemu/0004-slirp-Add-oob-eth-addr-to-netdev-options.patch

Peter Delevoryas (3):
net/ncsi: Simplify Kconfig/dts control flow net/ncsi: Fix netlink major/minor verison numbers net/ncsi: Add NC-SI 1.2 Get MC MAC Address command

 net/ncsi/internal.h     |  7 ++--
 net/ncsi/ncsi-cmd.c     |  3 +-
 net/ncsi/ncsi-manage.c  | 29 ++++++-----------
 net/ncsi/ncsi-netlink.c |  4 +--
 net/ncsi/ncsi-pkt.h     | 17 ++++++++--
 net/ncsi/ncsi-rsp.c     | 71 +++++++++++++++++++++++++++++++++++++++--
 6 files changed, 102 insertions(+), 29 deletions(-)
Signature · 1 line
2.30.2