Skip to content

RFC tcp: Fix bhash2 and TIME_WAIT regression.

Kuniyuki Iwashima netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest2 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2tcp: Add TIME_WAIT sockets in bhash2.include/net/inet_timewait_sock.h include/net/sock.h net/ipv4/inet_hashtables.c +1 more+37 -610 replies
2/2tcp: Add selftest for bind() and TIME_WAIT.tools/testing/selftests/net/.gitignore tools/testing/selftests/net/bind_timewait.c+94 -02 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by.

PatchJiri Slaby
1/2T-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH RFC net 0/2] tcp: Fix bhash2 and TIME_WAIT regression.

We forgot to add TIME_WAIT sockets to bhash2. Therefore twsk cannot prevent bind() to the same local address and port.

The first patch fixes the issue, but the layout change in struct sock could have a negative impact. So, this series is RFC.

Kuniyuki Iwashima (2):
tcp: Add TIME_WAIT sockets in bhash2.
tcp: Add selftest for bind() and TIME_WAIT.

 include/net/inet_timewait_sock.h            |  2 +
 include/net/sock.h                          |  5 +-
 net/ipv4/inet_hashtables.c                  |  5 +-
 net/ipv4/inet_timewait_sock.c               | 31 ++++++-
 tools/testing/selftests/net/.gitignore      |  1 +
 tools/testing/selftests/net/bind_timewait.c | 93 +++++++++++++++++++++
 6 files changed, 131 insertions(+), 6 deletions(-)
 create mode 100644 tools/testing/selftests/net/bind_timewait.c
Signature · 1 line
2.30.2