Skip to content

Add PinePhone Pro display support

Javier Martinez Canillas dri-devel linux-arm-kernel linux-devicetree lkml 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest3 patches 2 repliesIn review
  2. v44 patches 14 repliesSuperseded
  3. v34 patches 10 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v24 patches5 repliesSuperseded
v14 patches9 repliesSuperseded

Changes in v5 from the cover letter

- List Ondrej Jirman as a maintainer in the DT binding schema document.
- Add Peter Robinson's Tested-by tag.
- List Ondrej Jirman as a maintainer in the driver's MAINTAINERS entry.

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3dt-bindings: display: Add Himax HX8394 panel controllerDocumentation/devicetree/bindings/display/panel/himax,hx8394.yaml+76 -00 replies
2/3drm: panel: Add Himax HX8394 panel controller driverdrivers/gpu/drm/panel/Kconfig drivers/gpu/drm/panel/Makefile drivers/gpu/drm/panel/panel-himax-hx8394.c+464 -00 replies
3/3MAINTAINERS: Add entry for Himax HX8394 panel controller driverMAINTAINERS+8 -00 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchKrzysztof KozlowskiSam RavnborgTom FitzhenryPeter Robinson
1/3R-b
2/3R-b T-b T-b
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v5 thread

Cover letter [PATCH v5 0/3] Add PinePhone Pro display support

This series adds support for the display present in the PinePhone Pro.

Patch #1 adds a devicetree binding schema for panels based on the Himax HX8394 controller, such as the HSD060BHW4 720x1440 TFT LCD panel present in the PinePhone Pro. Patch #2 adds the panel driver for this controller and finally patch #3 adds an entry for the driver in MAINTAINERS file.

This version doesn't include the DTS changes, since Ondrej mentioned that there are still things to sort out before enabling it. The DTS bits will be proposed as a follow-up patch series.

This allows for example the Fedora distro to support the PinePhone Pro with a DTB provided by the firmware.

This is a v5 of the patch-set that addresses issues pointed out in v4:

https://lists.freedesktop.org/archives/dri-devel/2022-December/384810.html

The patches were tested on a PinePhone Pro Explorer Edition using a Fedora 37 Workstation image.

Best regards,
Javier

Changes in v5:
- List Ondrej Jirman as a maintainer in the DT binding schema document.
- Add Peter Robinson's Tested-by tag.
- List Ondrej Jirman as a maintainer in the driver's MAINTAINERS entry.

Changes in v4:
- Add fallback "himax,hx8394" compatible for the panel controller (Jagan Teki).
- Add Tom Fitzhenry's Tested-by tag.
- Add Sam Ravnborg's Acked-by tag.

Changes in v3:
- Fix example snippet for make dt_binding_check to pass (Krzysztof Kozlowski).
- Add Sam Ravnborg's reviwed-by tag.
- Move driver patch after one introducing the DT binding (Sam Ravnborg).

Changes in v2:
- Drop redundant "bindings" in subject (Krzysztof Kozlowski).
- Drop "device tree bindings" in title (Krzysztof Kozlowski).
- Put port next to other "true" properties (Krzysztof Kozlowski).
- Add Krzysztof Kozlowski's Reviewed-by tag.
- Add year to driver's copyright notice (Sam Ravnborg)
- Remove unused <video/display_timing.h> header include (Sam Ravnborg).
- Use mipi_dsi_dcs_write_seq() helper and drop custom macro (Sam Ravnborg).
- Drop unnecessary info messages and move useful one to debug (Sam Ravnborg).

Javier Martinez Canillas (2):
dt-bindings: display: Add Himax HX8394 panel controller
MAINTAINERS: Add entry for Himax HX8394 panel controller driver

Kamil Trzciński (1):
drm: panel: Add Himax HX8394 panel controller driver

 .../bindings/display/panel/himax,hx8394.yaml  |  76 +++
 MAINTAINERS                                   |   8 +
 drivers/gpu/drm/panel/Kconfig                 |  12 +
 drivers/gpu/drm/panel/Makefile                |   1 +
 drivers/gpu/drm/panel/panel-himax-hx8394.c    | 451 ++++++++++++++++++
 5 files changed, 548 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/himax,hx8394.yaml
 create mode 100644 drivers/gpu/drm/panel/panel-himax-hx8394.c
Signature · 1 line
2.38.1