Skip to content

mm: uffd-wp + change_protection() cleanups

David Hildenbrand linux-mm lkml llvm oe-kbuild-all 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2mm/userfaultfd: rely on vma->vm_page_prot in uffd_wp_range()mm/userfaultfd.c+13 -51 reply
2/2mm/mprotect: drop pgprot_t parameter from change_protection()include/linux/mm.h mm/mempolicy.c mm/mprotect.c +1 more+14 -91 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH v1 0/2] mm: uffd-wp + change_protection() cleanups

Based on linus/master and [1]:
"mm/userfaultfd: enable writenotify while userfaultfd-wp is enabled for a
VMA"

Cleanup page protection handling in uffd-wp when calling change_protection() and improve unprotecting uffd=wp in private mappings, trying to set PTEs writable again if possible just like we do during mprotect() when upgrading write permissions. Make the change_protection() interface harder to get wrong :)

I consider both pages primarily cleanups, although patch #1 fixes a corner case with uffd-wp and softdirty tracking for shmem. @Peter, please let me know if we should flag patch #1 as pure cleanup -- I have no idea how important softdirty tracking on shmem is.

Survives my simple test case + selftests/vm.

Last patch series before Christmas; happy holidays everyone!

Cc Andrew Morton <[email protected]>
Cc Peter Xu <[email protected]>
Cc Hugh Dickins <[email protected]>
Cc Andrea Arcangeli <[email protected]>
Cc Nadav Amit <[email protected]>

[1] https://lore.kernel.org/all/[email protected]/T/#u

David Hildenbrand (2):
mm/userfaultfd: rely on vma->vm_page_prot in uffd_wp_range() mm/mprotect: drop pgprot_t parameter from change_protection()

 include/linux/mm.h |  3 +--
 mm/mempolicy.c     |  3 +--
 mm/mprotect.c      | 14 +++++++++++---
 mm/userfaultfd.c   | 17 ++++++++++++-----
 4 files changed, 25 insertions(+), 12 deletions(-)
Signature · 1 line
2.38.1