Skip to content

virtio-net: don't busy poll for cvq command

Jason Wang lkml netdev virtualization 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest2 patches 39 repliesIn review
  2. v32 patches 9 repliesSuperseded
  3. v22 patches 24 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v14 patches48 repliesSuperseded

Changes in v4 from the cover letter

- Tweak the comments
- Tweak the changelog to explain the rx mode lost after resuming.
- No functional changes

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2virtio-net: convert rx mode setting to use workqueuedrivers/net/virtio_net.c+52 -31 reply
2/2virtio-net: add cond_resched() to the command waiting loopdrivers/net/virtio_net.c+3 -138 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchShannon Nelson
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH net-next v4 0/2] virtio-net: don't busy poll for cvq command

Hi all:

The code used to busy poll for cvq command which turns out to have several side effects:

1) infinite poll for buggy devices
2) bad interaction with scheduler

So this series tries to use cond_resched() in the waiting loop. Before doing this we need first make sure the cvq command is not executed in atomic environment, so we need first convert rx mode handling to a workqueue.

Note that, this doesn't try to solve the case that a malicous device may block networking stack (RTNL) or break freezer which requries more thought to gracefully exit and resend the commands.

Please review.

Changes since V3:

- Tweak the comments
- Tweak the changelog to explain the rx mode lost after resuming.
- No functional changes

Changes since V2:

- Don't use interrupt but cond_resched()

Changes since V1:

- use RTNL to synchronize rx mode worker
- use completion for simplicity
- don't try to harden CVQ command

Changes since RFC:

- switch to use BAD_RING in virtio_break_device()
- check virtqueue_is_broken() after being woken up
- use more_used() instead of virtqueue_get_buf() to allow caller to get buffers afterwards
- break the virtio-net device when timeout
- get buffer manually since the virtio core check more_used() instead

Jason Wang (2):
virtio-net: convert rx mode setting to use workqueue
virtio-net: add cond_resched() to the command waiting loop

 drivers/net/virtio_net.c | 59 +++++++++++++++++++++++++++++++++++++---
 1 file changed, 55 insertions(+), 4 deletions(-)
Signature · 1 line
2.39.3