Skip to content

genirq/affinity: Abstract APIs from managed irq affinity spread

Ming Lei linux-block lkml 1 version Applied

Status from this message: The following commit has been merged into the irq/core branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first

  1. v4 Latest6 patches 11 repliesApplied

Changes in v4 from the cover letter

- address comments from John, not export the API, given so far no module uses this symbol
- add maintainer entry for new added lib/group_cpus.c
- rebase on 6.2

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/6genirq/affinity: Remove the 'firstvec' parameter from irq_build_affinity_maskskernel/irq/affinity.c+2 -31 reply
2/6genirq/affinity: Pass affinity managed mask array to irq_build_affinity_maskskernel/irq/affinity.c+12 -161 reply
3/6genirq/affinity: Don't pass irq_affinity_desc array to irq_build_affinity_maskskernel/irq/affinity.c+24 -101 reply
4/6genirq/affinity: Rename irq_build_affinity_masks as group_cpus_evenlykernel/irq/affinity.c+121 -1210 replies
5/6genirq/affinity: Move group_cpus_evenly() into lib/MAINTAINERS include/linux/group_cpus.h kernel/irq/affinity.c +2 more+446 -3970 replies
6/6blk-mq: Build default queue map via group_cpus_evenly()block/blk-mq-cpumap.c+13 -501 reply

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchChristoph HellwigJohn GarryJens Axboe
SeriesR-b
1/6R-b R-b
2/6R-b R-b
3/6R-b R-b
4/6R-b
5/6R-b
6/6R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v4 thread

Cover letter [PATCH V4 0/6] genirq/affinity: Abstract APIs from managed irq affinity spread

Hello,

irq_build_affinity_masks() actually grouping CPUs evenly into each managed irq vector according to NUMA and CPU locality, and it is reasonable to abstract one generic API for grouping CPUs evenly, the idea is suggested by Thomas Gleixner.

group_cpus_evenly() is abstracted and put into lib/, so blk-mq can re-use it to build default queue mapping.

blk-mq IO perf data is observed as more stable, meantime with big improvement, see detailed data in the last patch.

Please consider it for v6.3!

V4:
- address comments from John, not export the API, given so far no module uses this symbol
- add maintainer entry for new added lib/group_cpus.c
- rebase on 6.2

V3:
- fix build failure in case of !CONFIG_SMP, only 6/7 is changed

V2:
- fix build failure in case of !CONFIG_SMP
- fix commit log typo
- fix memory leak in last patch
- add reviewed-by

Since RFC:
- remove RFC
- rebase on -next tree

Ming Lei (6):
genirq/affinity: Remove the 'firstvec' parameter from
irq_build_affinity_masks
genirq/affinity: Pass affinity managed mask array to
irq_build_affinity_masks
genirq/affinity: Don't pass irq_affinity_desc array to
irq_build_affinity_masks
genirq/affinity: Rename irq_build_affinity_masks as group_cpus_evenly genirq/affinity: Move group_cpus_evenly() into lib/
blk-mq: Build default queue map via group_cpus_evenly()

 MAINTAINERS                |   2 +
 block/blk-mq-cpumap.c      |  63 ++----
 include/linux/group_cpus.h |  14 ++
 kernel/irq/affinity.c      | 405 +----------------------------------
 lib/Makefile               |   2 +
 lib/group_cpus.c           | 427 +++++++++++++++++++++++++++++++++++++
 6 files changed, 467 insertions(+), 446 deletions(-)
 create mode 100644 include/linux/group_cpus.h
 create mode 100644 lib/group_cpus.c
Signature · 1 line
2.31.1