hw/arm/aspeed_ast10x0: Map more peripherals & few more fixes
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest11 patches 27 repliesIn review
- v19 patches 17 repliesSuperseded
Changes in v2 from the cover letter
- Fixed typo (Peter)
- Link HACE with sram insted of secsram
- Split patch #2 in 2, reworded it
- Cover more WDT registers (new patch)
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/11 | hw/watchdog/wdt_aspeed: Rename MMIO region size as 'iosize'hw/ hw/ hw/ +2 more | +8 | 4 replies | |
| 2/11 | hw/watchdog/wdt_aspeed: Extend MMIO range to cover more registershw/ | +2 | 9 replies | |
| 3/11 | hw/watchdog/wdt_aspeed: Log unimplemented registers as UNIMP levelhw/ include/ | +14 | 2 replies | |
| 4/11 | hw/arm/aspeed: Use the IEC binary prefix definitionshw/ hw/ hw/ | +6 | 5 replies | |
| 5/11 | hw/misc/aspeed_hace: Do not crash if address_space_map() failedhw/ | +15 | 1 reply | |
| 6/11 | hw/arm/aspeed_ast10x0: Add various unimplemented peripheralshw/ include/ | +46 | 1 reply | |
| 7/11 | hw/arm/aspeed_ast10x0: Map I3C peripheralhw/ | +16 | 1 reply | |
| 8/11 | hw/arm/aspeed_ast10x0: Map the secure SRAMhw/ include/ | +13 | 1 reply | |
| 9/11 | hw/arm/aspeed_ast10x0: Map HACE peripheralhw/ | +15 | 1 reply | |
| 10/11 | hw/arm/aspeed_ast10x0: Add TODO comment to use Cortex-M4Fhw/ | +1 | 1 reply | |
| 11/11 | tests/avocado: Test Aspeed Zephyr SDK v00.01.08 on AST1030 boardtests/ | +40 | 1 reply |
Reviews trailers per patch
All 11 patches have a Reviewed-by or Acked-by.
| Patch | Peter Delevoryas | Cédric Le Goater |
|---|---|---|
| 1/11 | R-b | |
| 2/11 | R-b | |
| 3/11 | R-b | |
| 4/11 | R-b | R-b |
| 5/11 | R-b | R-b |
| 6/11 | R-b | R-b |
| 7/11 | R-b | R-b |
| 8/11 | R-b | |
| 9/11 | R-b | R-b |
| 10/11 | R-b | R-b |
| 11/11 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 00/11] hw/arm/aspeed_ast10x0: Map more peripherals & few more fixes
Missing review: #3
Since v1:
- Fixed typo (Peter)
- Link HACE with sram insted of secsram
- Split patch #2 in 2, reworded it
- Cover more WDT registers (new patch)
---
Trying to fix some bugs triggered running Zephyr.
Still 2 bugs:
1/
uart:~$ sensor get SYSCLK [00:00:23.592,000] <err> os: ***** USAGE FAULT ***** [00:00:23.593,000] <err> os: Illegal use of the EPSR [00:00:23.593,000] <err> os: r0/a1: 0x00033448 r1/a2: 0x00000000 r2/a3: 0x00047f50 [00:00:23.593,000] <err> os: r3/a4: 0x00000000 r12/ip: 0x00000000 r14/lr: 0x00000fbd [00:00:23.593,000] <err> os: xpsr: 0x60000000 [00:00:23.593,000] <err> os: Faulting instruction address (r15/pc): 0x00000000 [00:00:23.593,000] <err> os: >>> ZEPHYR FATAL ERROR 0: CPU exception on CPU 0 [00:00:23.594,000] <err> os: Current thread: 0x38248 (shell_uart) [00:00:23.601,000] <err> os: Halting system
2/
uart:~$ mcuboot [00:01:04.990,000] <err> os: ***** BUS FAULT ***** [00:01:04.990,000] <err> os: Instruction bus error [00:01:04.991,000] <err> os: r0/a1: 0x00000000 r1/a2: 0x000ffff0 r2/a3: 0x00047ef0 [00:01:04.991,000] <err> os: r3/a4: 0x00000010 r12/ip: 0x6df7ecb5 r14/lr: 0x000188ed [00:01:04.991,000] <err> os: xpsr: 0x61000000 [00:01:04.991,000] <err> os: Faulting instruction address (r15/pc): 0x6df7ecb4 [00:01:04.991,000] <err> os: >>> ZEPHYR FATAL ERROR 0: CPU exception on CPU 0 [00:01:04.991,000] <err> os: Current thread: 0x38248 (shell_uart) [00:01:04.994,000] <err> os: Halting system
----------------
IN:
PMSA MPU lookup for reading at 0x0001d400 mmu_idx 65 -> Hit (prot rwx)
0x0001d5a2: 6869 ldr r1, [r5, #4]
0x0001d5a4: 4421 add r1, r4
0x0001d5a6: 6883 ldr r3, [r0, #8]
0x0001d5a8: 681c ldr r4, [r3]
0x0001d5aa: 463a mov r2, r7
0x0001d5ac: 4633 mov r3, r6
0x0001d5ae: 46a4 mov ip, r4
0x0001d5b0: e8bd 41f0 pop.w {r4, r5, r6, r7, r8, lr}
0x0001d5b4: 4760 bx ipPMSA MPU lookup for reading at 0x00000008 mmu_idx 65 -> Hit (prot rwx) PMSA MPU lookup for execute at 0x6df7ecb4 mmu_idx 65 -> Hit (prot rwx) Taking exception 3 [Prefetch Abort] on CPU 0
...at fault address 0x6df7ecb4
...with CFSR.IBUSERR
PMSA MPU lookup for writing at 0x00047ec8 mmu_idx 65 -> Hit (prot rwx) PMSA MPU lookup for writing at 0x00047ecc mmu_idx 65 -> Hit (prot rwx) PMSA MPU lookup for writing at 0x00047ed0 mmu_idx 65 -> Hit (prot rwx) PMSA MPU lookup for writing at 0x00047ed4 mmu_idx 65 -> Hit (prot rwx) PMSA MPU lookup for writing at 0x00047ed8 mmu_idx 65 -> Hit (prot rwx) PMSA MPU lookup for writing at 0x00047edc mmu_idx 65 -> Hit (prot rwx) PMSA MPU lookup for writing at 0x00047ee0 mmu_idx 65 -> Hit (prot rwx) PMSA MPU lookup for writing at 0x00047ee4 mmu_idx 65 -> Hit (prot rwx) ...taking pending nonsecure exception 5
...loading from element 5 of non-secure vector table at 0x14 ...loaded new PC 0xa0cd
----------------
Philippe Mathieu-Daudé (11):
hw/watchdog/wdt_aspeed: Rename MMIO region size as 'iosize' hw/watchdog/wdt_aspeed: Extend MMIO range to cover more registers hw/watchdog/wdt_aspeed: Log unimplemented registers as UNIMP level hw/arm/aspeed: Use the IEC binary prefix definitions hw/misc/aspeed_hace: Do not crash if address_space_map() failed hw/arm/aspeed_ast10x0: Add various unimplemented peripherals hw/arm/aspeed_ast10x0: Map I3C peripheral hw/arm/aspeed_ast10x0: Map the secure SRAM hw/arm/aspeed_ast10x0: Map HACE peripheral hw/arm/aspeed_ast10x0: Add TODO comment to use Cortex-M4F tests/avocado: Test Aspeed Zephyr SDK v00.01.08 on AST1030 board
hw/arm/aspeed_ast10x0.c | 84 ++++++++++++++++++++++++++++++-- hw/arm/aspeed_ast2600.c | 5 +- hw/arm/aspeed_soc.c | 6 +-- hw/misc/aspeed_hace.c | 21 +++++--- hw/watchdog/wdt_aspeed.c | 24 +++++++-- include/hw/arm/aspeed_soc.h | 14 ++++++ include/hw/watchdog/wdt_aspeed.h | 4 +- tests/avocado/machine_aspeed.py | 41 +++++++++++++++- 8 files changed, 176 insertions(+), 23 deletions(-)
Signature · 1 line
2.38.1