Skip to content

net: ipa: simplify IPA interrupt handling

Alex Elder linux-arm-msm lkml netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 1 replyIn review 5 of 6 applied
  2. v16 patches 5 repliesSuperseded

Patches in v2 5 of 6 applied

#Subject and filesSizeRepliesApplied
1/6net: ipa: introduce a common microcontroller interrupt handlerdrivers/net/ipa/ipa_uc.c+15 -40 repliesApplied
2/6net: ipa: introduce ipa_interrupt_enable()drivers/net/ipa/ipa_interrupt.c+25 -160 repliesApplied
3/6net: ipa: enable IPA interrupt handlers separate from registrationdrivers/net/ipa/ipa_interrupt.c drivers/net/ipa/ipa_interrupt.h drivers/net/ipa/ipa_power.c +1 more+26 -70 repliesApplied
4/6net: ipa: register IPA interrupt handlers directlydrivers/net/ipa/ipa_interrupt.c drivers/net/ipa/ipa_power.c drivers/net/ipa/ipa_power.h +2 more+31 -210 repliesApplied
5/6net: ipa: kill ipa_interrupt_add()drivers/net/ipa/ipa_interrupt.c drivers/net/ipa/ipa_interrupt.h drivers/net/ipa/ipa_power.c +1 more+3 -590 repliesApplied
6/6net: ipa: don't maintain IPA interrupt handler arraydrivers/net/ipa/ipa_interrupt.c+20 -260 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH net-next v2 0/6] net: ipa: simplify IPA interrupt handling

One of the IPA's two IRQs fires when data on a suspended channel is available (to request that the channel--or system--be resumed to recieve the pending data). This interrupt also handles a few conditions signaled by the embedded microcontroller.

For this "IPA interrupt", the current code requires a handler to be dynamically registered for each interrupt condition. Any condition that has no registered handler is quietly ignored. This design is derived from the downstream IPA driver implementation.

There isn't any need for this complexity. Even in the downstream code, only four of the available 30 or so IPA interrupt conditions are ever handled. So these handlers can pretty easily just be called directly in the main IRQ handler function.

This series simplifies the interrupt handling code by having the small number of IPA interrupt handlers be called directly, rather than having them be registered dynamically.

Version 2 just adds a missing forward-reference, as suggested by Caleb.

-Alex

Alex Elder (6):
net: ipa: introduce a common microcontroller interrupt handler
net: ipa: introduce ipa_interrupt_enable()
net: ipa: enable IPA interrupt handlers separate from registration
net: ipa: register IPA interrupt handlers directly
net: ipa: kill ipa_interrupt_add()
net: ipa: don't maintain IPA interrupt handler array

 drivers/net/ipa/ipa_interrupt.c | 103 ++++++++++++++------------------
 drivers/net/ipa/ipa_interrupt.h |  48 +++++----------
 drivers/net/ipa/ipa_power.c     |  19 ++----
 drivers/net/ipa/ipa_power.h     |  12 ++++
 drivers/net/ipa/ipa_uc.c        |  21 +++++--
 drivers/net/ipa/ipa_uc.h        |   8 +++
 6 files changed, 99 insertions(+), 112 deletions(-)
Signature · 1 line
2.34.1