Skip to content

Improve signals and avoid losing high priority ones

[email protected]... openvpn-devel 1 version In review

Get series with b4
b4 am [email protected]...

Versions newest first

  1. v1 Latest5 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5Preparing for better signal handling: some code refactoringsrc/openvpn/dco_win.c src/openvpn/dco_win.h src/openvpn/forward.c +13 more+125 -1301 reply
2/5Refactor signal handling in openvpn_getaddrinfosrc/openvpn/socket.c src/openvpn/socket.h+18 -171 reply
3/5Assign and honour signal priority ordersrc/openvpn/proxy.c src/openvpn/sig.c src/openvpn/socket.c +1 more+44 -282 replies
4/5Fix signal handling on Windowssrc/openvpn/manage.c src/openvpn/win32.c+68 -348 replies
5/5Improve signal handling using POSIX sigactionsrc/openvpn/init.c src/openvpn/multi.c src/openvpn/openvpn.c +3 more+239 -864 replies

Reviews trailers per patch

4 of 5 patches have a Reviewed-by or Acked-by.

PatchGert DoeringLev StipakovArne Schwabe
1/5A-b
2/5A-b
3/5A-b
4/5A-b
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [Openvpn-devel] [PATCH 0/5] Improve signals and avoid losing high priority ones

From: Selva Nair <[email protected]...>

Back to my long-forgotten signal patch -- cleaned up and rebased. What better to do on a Jan 1st afternoon...

Commits:

1.  Preparing for better signal handling: some code refactoring
2.  Refactor signal handling in openvpn_getaddrinfo
3.  Assign and honour signal priority order
4.  Fix signal handling on Windows
5.  Improve signal handling using POSIX sigaction

Commits 1 to 4 are fairly non-intrusive and should fix trac #639 and #311 (or github #205) for most practical purposes.

Commit 5 rewrites sig.c using sigaction for proper masking of signals during updates. May be too intrusive and too late to get well-tested for 2.6.