Skip to content

Resolve TYPE_PIIX3_XEN_DEVICE

Bernhard Beschow qemu-devel xen-devel 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest7 patches 11 repliesIn review
  2. v36 patches 14 repliesSuperseded
  3. v26 patches 39 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v16 patches11 repliesSuperseded

Changes in v4 from the cover letter

- Add patch fixing latent memory leak in pci_bus_irqs() (Anthony)

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7include/hw/xen/xen: Rename xen_piix3_set_irq() to xen_intx_set_irq()hw/i386/xen/xen-hvm.c hw/isa/piix3.c include/hw/xen/xen.h +1 more+5 -50 replies
2/7hw/pci/pci.c: Don't leak PCIBus::irq_count[] in pci_bus_irqs()hw/pci/pci.c+2 -02 replies
3/7hw/isa/piix3: Reuse piix3_realize() in piix3_xen_realize()hw/isa/piix3.c+1 -10 replies
4/7hw/isa/piix3: Wire up Xen PCI IRQ handling outside of PIIX3hw/i386/pc_piix.c hw/isa/piix3.c+14 -230 replies
5/7hw/isa/piix3: Avoid Xen-specific variant of piix3_write_config()hw/i386/pc_piix.c hw/isa/piix3.c+19 -210 replies
6/7hw/isa/piix3: Resolve redundant k->config_write assignmentshw/isa/piix3.c+1 -20 replies
7/7hw/isa/piix3: Resolve redundant TYPE_PIIX3_XEN_DEVICEhw/i386/pc_piix.c hw/isa/piix3.c include/hw/southbridge/piix.h+2 -190 replies

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchChuck ZmudzinskiMichael S. TsirkinAnthony PERARD
SeriesT-b
1/7T-b R-b R-b
2/7R-b
3/7T-b R-b R-b
4/7T-b R-b R-b
5/7T-b R-b R-b
6/7T-b R-b R-b
7/7T-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v4 thread

Cover letter [PATCH v4 0/7] Resolve TYPE_PIIX3_XEN_DEVICE

There is currently a dedicated PIIX3 device model for use under Xen. By reusing existing PCI API during initialization this device model can be eliminated and the plain PIIX3 device model can be used instead.

Resolving TYPE_PIIX3_XEN_DEVICE results in less code while also making Xen agnostic towards the precise south bridge being used in the PC machine. The latter might become particularily interesting once PIIX4 becomes usable in the PC machine, avoiding the "Frankenstein" use of PIIX4_ACPI in PIIX3.

Testing done:
- make check
- Run xl create with the following config:

    name = "Manjaro"
    type = 'hvm'
    memory = 1536
    apic = 1
    usb = 1
    disk = [ "file:manjaro-kde-21.2.6-220416-linux515.iso,hdc:cdrom,r" ]
    device_model_override = "/usr/bin/qemu-system-x86_64"
    vga = "stdvga"
    sdl = 1
- `qemu-system-x86_64 -M pc -m 2G -cpu host -accel kvm \
    -cdrom manjaro-kde-21.2.6-220416-linux515.iso`

v4:
- Add patch fixing latent memory leak in pci_bus_irqs() (Anthony)

v3:
- Rebase onto master

v2:
- xen_piix3_set_irq() is already generic. Just rename it. (Chuck)

Bernhard Beschow (7):
include/hw/xen/xen: Rename xen_piix3_set_irq() to xen_intx_set_irq() hw/pci/pci.c: Don't leak PCIBus::irq_count[] in pci_bus_irqs() hw/isa/piix3: Reuse piix3_realize() in piix3_xen_realize() hw/isa/piix3: Wire up Xen PCI IRQ handling outside of PIIX3 hw/isa/piix3: Avoid Xen-specific variant of piix3_write_config() hw/isa/piix3: Resolve redundant k->config_write assignments hw/isa/piix3: Resolve redundant TYPE_PIIX3_XEN_DEVICE

 include/hw/southbridge/piix.h |  1 -
 include/hw/xen/xen.h          |  2 +-
 hw/i386/pc_piix.c             | 36 +++++++++++++++++++--
 hw/i386/xen/xen-hvm.c         |  2 +-
 hw/isa/piix3.c                | 60 +----------------------------------
 hw/pci/pci.c                  |  2 ++
 stubs/xen-hw-stub.c           |  2 +-
 7 files changed, 39 insertions(+), 66 deletions(-)
Signature · 1 line
2.40.0