RFC Generic function based cache management operations (was Re: [PATCH v5 6/6] soc: renesas: Add L2 cache management for RZ/Five SoC)
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest9 patches 14 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | riscv: asm: alternative-macros: Introduce ALTERNATIVE_3() macroarch/ | +41 | 0 replies | |
| 2/9 | riscv: asm: vendorid_list: Add Andes Technology to the vendors listarch/ | +1 | 0 replies | |
| 3/9 | riscv: errata: Add Andes alternative portsarch/ arch/ arch/ +4 more | +130 | 0 replies | |
| 4/9 | riscv: mm: dma-noncoherent: Pass direction and operation to ALT_CMO_OP()arch/ arch/ arch/ +1 more | +22 | 0 replies | |
| 5/9 | dt-bindings: cache: r9a07g043f-l2-cache: Add DT binding documentation for L2 cache controllerDocumentation/ | +81 | 0 replies | |
| 6/9 | cache,soc: Move SiFive CCache driver & create drivers/cacheMAINTAINERS drivers/ drivers/ +7 more | +21 | 2 replies | |
| 7/9 | RISC-V: create a function based cache management interfacearch/ arch/ arch/ | +44 | 0 replies | |
| 8/9 | soc: renesas: Add L2 cache management for RZ/Five SoCarch/ drivers/ drivers/ +2 more | +290 | 0 replies | |
| 9/9 | cache: sifive-ccache: add cache flushing capabilitydrivers/ | +45 | 12 replies |
Reviews trailers per patch
3 of 9 patches have a Reviewed-by or Acked-by.
| Patch | Heiko Stuebner | Conor Dooley | Rob Herring |
|---|---|---|---|
| 1/9 | R-b | R-b | |
| 2/9 | R-b | R-b | |
| 3/9 | |||
| 4/9 | |||
| 5/9 | R-b | ||
| 6/9 | |||
| 7/9 | |||
| 8/9 | |||
| 9/9 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [RFC v5.1 0/9] Generic function based cache management operations (was Re: [PATCH v5 6/6] soc: renesas: Add L2 cache management for RZ/Five SoC)
From: Conor Dooley <[email protected]>
Hey all, hopefully the $subject arrived intact!
See here for prior discussion:
https://lore.kernel.org/linux-riscv/Y62nOqzyuUKqYDpq@spud/#R
Rather than continue that back and forth about where these drivers belonged, I've gone and created a mock-up for what it would look like if we picked drivers/cache.
IMO, doing drivers/cache for the detail of vendor behaviour makes sense as it'll keep 'em out of arch/riscv while keeping the drivers together.
I've taken v5 of Prabhakar's patchset & hacked at it a bit, so here is a tyre-kicked (more) generic implementation of cache management stuff via functions.
I initially went and moved both the ax45mp and ccache drivers to drivers/cache & created a "subsystem" like interface, but quickly realised it was all far too trivial to exist & was intrinsically tied to the ALT_CMO_OP alternative setup on RISC-V.
I trashed that so, and instead copied the interface currently used by riscv_set_cacheinfo_ops(), and created a corollary which registers cache management operations. Or maintenance, IDC which.
Instead of having the vendor specific cache controller function in the errata, the generic one is there instead, which then calls the one registered by the vendor driver.
I figure that even if no other non-coherent implementation ends up making it upstream, ax45mp is not going to be the only Andestech product that has a "no-iocp" variant...
I sent this over the Prabhakar the other day & it works for him, so I am now sending this here as RFC. I've not yet tested it on PolarFire SoC, as we have to sort out some "fun" where archid etc are all zero. We'll require some massaging before we can use the alternatives framework as is, so that'll have to come at a later date. I included a patch, but it's marked "DON'T APPLY" for a reason ;)
Notably, I have not fixed up any comments which were left against v5, bar a rebase on top of riscv/for-next. I blindly "fixed" the pmem issue, so that needs to be fixed properly for a v6, alongside the other couple bits.
The other thing that is missing, and I could not think immediately of a way to do it, is a way to add additional users of this type of CMO to the alternative without having to add a specific entry for each vendor. I had first thought about using archid of 0, but that runs into problems pretty quickly as that "archid" is what we use for enabling CPU_FEATURE stuff, like Zicbom itself.
Since archid uses the JEDEC IDs, perhaps we could squat on either a continuation code (or some vendor that won't make a RISC-V CPU, like Actel *cough*).
I didn't go through with mocking that up, as until we sort out PolarFire SoC, there's only one user for this that I, at least, would like to have supported properly.
So if anyone has ideas that are in any way less hacky than that, I am all ears.
Thanks,
Conor.
Conor Dooley (2):
cache,soc: Move SiFive CCache driver & create drivers/cache
RISC-V: create a function based cache management interface
Daire McNamara (1):
[DON'T APPLY] cache: sifive-ccache: add cache flushing capability
Lad Prabhakar (6):
riscv: asm: alternative-macros: Introduce ALTERNATIVE_3() macro
riscv: asm: vendorid_list: Add Andes Technology to the vendors list
riscv: errata: Add Andes alternative ports
riscv: mm: dma-noncoherent: Pass direction and operation to
ALT_CMO_OP()
dt-bindings: cache: r9a07g043f-l2-cache: Add DT binding documentation
for L2 cache controller
soc: renesas: Add L2 cache management for RZ/Five SoC
.../cache/andestech,ax45mp-cache.yaml | 81 ++++++
MAINTAINERS | 15 +-
arch/riscv/Kconfig.erratas | 26 ++
arch/riscv/errata/Makefile | 1 +
arch/riscv/errata/andes/Makefile | 1 +
arch/riscv/errata/andes/errata.c | 93 +++++++
arch/riscv/include/asm/alternative-macros.h | 46 +++-
arch/riscv/include/asm/alternative.h | 3 +
arch/riscv/include/asm/cacheflush.h | 23 ++
arch/riscv/include/asm/errata_list.h | 41 ++-
arch/riscv/include/asm/vendorid_list.h | 1 +
arch/riscv/kernel/alternative.c | 5 +
arch/riscv/mm/dma-noncoherent.c | 36 ++-
arch/riscv/mm/pmem.c | 4 +-
drivers/Kconfig | 2 +
drivers/Makefile | 2 +
drivers/cache/Kconfig | 25 ++
drivers/{soc/sifive => cache}/Makefile | 2 +
drivers/cache/ax45mp_cache.c | 253 ++++++++++++++++++
drivers/{soc/sifive => cache}/sifive_ccache.c | 47 +++-
drivers/edac/sifive_edac.c | 2 +-
drivers/soc/Kconfig | 1 -
drivers/soc/Makefile | 1 -
drivers/soc/renesas/Kconfig | 4 +
drivers/soc/sifive/Kconfig | 10 -
include/{soc/sifive => cache}/sifive_ccache.h | 0
26 files changed, 684 insertions(+), 41 deletions(-)
create mode 100644 Documentation/devicetree/bindings/cache/andestech,ax45mp-cache.yaml
create mode 100644 arch/riscv/errata/andes/Makefile
create mode 100644 arch/riscv/errata/andes/errata.c
create mode 100644 drivers/cache/Kconfig
rename drivers/{soc/sifive => cache}/Makefile (62%)
create mode 100644 drivers/cache/ax45mp_cache.c
rename drivers/{soc/sifive => cache}/sifive_ccache.c (86%)
delete mode 100644 drivers/soc/sifive/Kconfig
rename include/{soc/sifive => cache}/sifive_ccache.h (100%)base-commit: b07de94d4501c61a3015cb0035227e449c51d87e
Signature · 1 line
2.39.0