devlink: code split and structured instance walk
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest15 patches 16 repliesIn review 13 of 15 applied
- v114 patches 27 repliesSuperseded
Changes in v2 from the cover letter
- various renames
- split patch 2
Patches in v2 13 of 15 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/15 | devlink: move code to a dedicated directorynet/ net/ net/ +1 more | +4 | 1 reply | |
| 2/15 | devlink: rename devlink_netdevice_event -> devlink_port_netdevice_eventnet/ | +5 | 1 reply | Applied |
| 3/15 | devlink: split out core codenet/ net/ net/ +1 more | +476 | 4 replies | |
| 4/15 | devlink: split out netlink codenet/ net/ net/ +1 more | +235 | 1 reply | Applied |
| 5/15 | netlink: add macro for checking dump ctx sizeinclude/ net/ | +5 | 2 replies | Applied |
| 6/15 | devlink: use an explicit structure for dump contextnet/ net/ | +81 | 1 reply | Applied |
| 7/15 | devlink: remove start variables from dumpsnet/ | +19 | 1 reply | Applied |
| 8/15 | devlink: drop the filter argument from devlinks_xa_find_getnet/ net/ | +10 | 0 replies | Applied |
| 9/15 | devlink: health: combine loops in dumpnet/ | +0 | 0 replies | Applied |
| 10/15 | devlink: restart dump based on devlink instance ids (simple)net/ net/ net/ | +25 | 1 reply | Applied |
| 11/15 | devlink: restart dump based on devlink instance ids (nested)net/ net/ | +49 | 0 replies | Applied |
| 12/15 | devlink: restart dump based on devlink instance ids (function)net/ | +21 | 0 replies | Applied |
| 13/15 | devlink: uniformly take the devlink instance lock in the dump loopnet/ | +6 | 0 replies | Applied |
| 14/15 | devlink: add by-instance dump infranet/ net/ net/ | +68 | 4 replies | Applied |
| 15/15 | devlink: convert remaining dumps to the by-instance schemenet/ net/ net/ | +320 | 0 replies | Applied |
Reviews trailers per patch
All 15 patches have a Reviewed-by or Acked-by.
| Patch | Jacob Keller | Jiri Pirko |
|---|---|---|
| 1/15 | R-b | R-b |
| 2/15 | R-b | |
| 3/15 | R-b R-b | R-b |
| 4/15 | R-b | R-b |
| 5/15 | R-b | R-b |
| 6/15 | R-b | R-b |
| 7/15 | R-b | R-b |
| 8/15 | R-b | R-b |
| 9/15 | R-b | R-b |
| 10/15 | R-b | R-b |
| 11/15 | R-b | R-b |
| 12/15 | R-b | R-b |
| 13/15 | R-b | R-b |
| 14/15 | R-b | |
| 15/15 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH net-next v2 00/15] devlink: code split and structured instance walk
Split devlink.c into a handful of files, trying to keep the "core" code away from all the command-specific implementations. The core code has been quite scattered until now. Going forward we can consider using a source file per-subobject, I think that it's quite beneficial to newcomers (based on relative ease with which folks contribute to ethtool vs devlink). But this series doesn't split everything out, yet - partially due to backporting concerns, but mostly due to lack of time. Bulk of the netlink command handling is left in a leftover.c file.
Introduce a context structure for dumps, and use it to store the devlink instance ID of the last dumped devlink instance. This means we don't have to restart the walk from 0 each time.
Finally - introduce a "structured walk". A centralized dump handler in devlink/netlink.c which walks the devlink instances, deals with refcounting/locking, simplifying the per-object implementations quite a bit. Inspired by the ethtool code.
v2:
- various renames
- split patch 2
v1: https://lore.kernel.org/all/[email protected]/
- re-route the locking fix via net
- rename basic.c -> leftover.c
RFC: https://lore.kernel.org/all/[email protected]/
Jakub Kicinski (15):
devlink: move code to a dedicated directory
devlink: rename devlink_netdevice_event ->
devlink_port_netdevice_event
devlink: split out core code
devlink: split out netlink code
netlink: add macro for checking dump ctx size
devlink: use an explicit structure for dump context
devlink: remove start variables from dumps
devlink: drop the filter argument from devlinks_xa_find_get
devlink: health: combine loops in dump
devlink: restart dump based on devlink instance ids (simple)
devlink: restart dump based on devlink instance ids (nested)
devlink: restart dump based on devlink instance ids (function)
devlink: uniformly take the devlink instance lock in the dump loop
devlink: add by-instance dump infra
devlink: convert remaining dumps to the by-instance scheme
include/linux/netlink.h | 4 +
net/Makefile | 1 +
net/core/Makefile | 1 -
net/devlink/Makefile | 3 +
net/devlink/core.c | 345 +++++
net/devlink/devl_internal.h | 207 +++
net/{core/devlink.c => devlink/leftover.c} | 1460 +++++---------------
net/devlink/netlink.c | 242 ++++
net/netfilter/nf_conntrack_netlink.c | 2 +-
9 files changed, 1160 insertions(+), 1105 deletions(-)
create mode 100644 net/devlink/Makefile
create mode 100644 net/devlink/core.c
create mode 100644 net/devlink/devl_internal.h
rename net/{core/devlink.c => devlink/leftover.c} (90%)
create mode 100644 net/devlink/netlink.cSignature · 1 line
2.38.1