Skip to content

s390x/pv: Improve error reporting of protected VMs

Cédric Le Goater qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 5 repliesIn review
  2. v24 patches 16 repliesSuperseded
  3. v15 patches 12 repliesSuperseded

Changes in v3 from the cover letter

- dropped 's390x/pv: Check for support on the host'. This is already covered by the KVM capability.
- in s390_pv_check() (patch 2) drop the call to s390_pv_guest_check() since init time has already checked the same conditions. However, to report an error when the machine is not protected and the kernel secure, we still need s390_pv_check().

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3s390x/pv: Implement a CGS check helperhw/s390x/pv.c+40 -00 replies
2/3s390x/pv: Introduce a s390_pv_check() helper for runtimehw/s390x/pv.c include/hw/s390x/pv.h target/s390x/diag.c+22 -05 replies
3/3s390x/pv: Move check on hugepage under s390_pv_guest_check()hw/s390x/pv.c target/s390x/diag.c+12 -80 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchThomas Huth
1/3R-b
2/3
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/3]s390x/pv: Improve error reporting of protected VMs

Hello,

Here is a little series improving error reporting of protected VMs.

Thanks,

C.

Changes in v3:

- dropped 's390x/pv: Check for support on the host'. This is already covered by the KVM capability.
- in s390_pv_check() (patch 2) drop the call to s390_pv_guest_check() since init time has already checked the same conditions. However, to report an error when the machine is not protected and the kernel secure, we still need s390_pv_check().

Changes in v2:

- dropped ConfidentialGuestSupportClass handler. The check is now done from s390_pv_init() which is called after memory and CPU initialization. This gives us a better chance to tune the limits correctly.
- pv_max_cpus now computed from the available size of the response buffer of the Read SCP Info Service Call (Thomas)

Cédric Le Goater (3):
s390x/pv: Implement a CGS check helper
s390x/pv: Introduce a s390_pv_check() helper for runtime s390x/pv: Move check on hugepage under s390_pv_guest_check()

 include/hw/s390x/pv.h |  2 ++
 hw/s390x/pv.c         | 64 +++++++++++++++++++++++++++++++++++++++++++
 target/s390x/diag.c   |  6 ++--
 3 files changed, 69 insertions(+), 3 deletions(-)
Signature · 1 line
2.39.0