Skip to content

hw/mips/gt64xxx_pci: Fix endianness swap on big-endian hosts

Philippe Mathieu-Daudé qemu-devel 1 version Applied

Status from this message: Applied to mips-next.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 6 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/6hw/pci/pci_host: Trace config accesses on unexisting functionshw/pci/pci_host.c+6 -00 replies
2/6hw/mips/malta: Split FPGA LEDs/ASCII display updateshw/mips/malta.c+8 -50 replies
3/6hw/mips/malta: Trace FPGA LEDs/ASCII display updateshw/mips/malta.c hw/mips/trace-events+7 -00 replies
4/6hw/mips/gt64xxx_pci: Accumulate address space changeshw/mips/gt64xxx_pci.c+8 -00 replies
5/6hw/mips/gt64xxx_pci: Endian-swap using PCI_HOST_BRIDGE MemoryRegionOpshw/mips/gt64xxx_pci.c+50 -203 replies
6/6tests/avocado: Add tests booting YAMON ROM on MIPS Malta machinestests/avocado/machine_mips_malta.py+48 -41 reply

Reviews trailers per patch

None of the 6 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchRichard Henderson
SeriesR-b
1/6
2/6
3/6
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/6] hw/mips/gt64xxx_pci: Fix endianness swap on big-endian hosts

While working on endianness consolidation I figured a long-standing bug in the GT64120 while accessing PCI config/data registers from the CPU bus (via the ISD).
While the debugging was painful, the fix is quite
easy: simply use the endianness MemoryRegionOps provided by the abstract PCI_HOST_BRIDGE class.

Patches 1-3 were useful while debugging. patch 5 is the fix and patch 6 add a test to keep testing on BE hosts.

Philippe Mathieu-Daudé (6):
hw/pci/pci_host: Trace config accesses on unexisting functions hw/mips/malta: Split FPGA LEDs/ASCII display updates hw/mips/malta: Trace FPGA LEDs/ASCII display updates hw/mips/gt64xxx_pci: Accumulate address space changes hw/mips/gt64xxx_pci: Endian-swap using PCI_HOST_BRIDGE MemoryRegionOps tests/avocado: Add tests booting YAMON ROM on MIPS Malta machines

 hw/mips/gt64xxx_pci.c               | 78 +++++++++++++++++++++--------
 hw/mips/malta.c                     | 16 ++++--
 hw/mips/trace-events                |  4 ++
 hw/pci/pci_host.c                   |  6 +++
 tests/avocado/machine_mips_malta.py | 52 +++++++++++++++++--
 5 files changed, 127 insertions(+), 29 deletions(-)
Signature · 1 line
2.38.1