hw/mips/gt64xxx_pci: Fix endianness swap on big-endian hosts
Status from this message: Applied to mips-next.
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | hw/pci/pci_host: Trace config accesses on unexisting functionshw/ | +6 | 0 replies | |
| 2/6 | hw/mips/malta: Split FPGA LEDs/ASCII display updateshw/ | +8 | 0 replies | |
| 3/6 | hw/mips/malta: Trace FPGA LEDs/ASCII display updateshw/ hw/ | +7 | 0 replies | |
| 4/6 | hw/mips/gt64xxx_pci: Accumulate address space changeshw/ | +8 | 0 replies | |
| 5/6 | hw/mips/gt64xxx_pci: Endian-swap using PCI_HOST_BRIDGE MemoryRegionOpshw/ | +50 | 3 replies | |
| 6/6 | tests/avocado: Add tests booting YAMON ROM on MIPS Malta machinestests/ | +48 | 1 reply |
Reviews trailers per patch
None of the 6 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Richard Henderson |
|---|---|
| Series | R-b |
| 1/6 | |
| 2/6 | |
| 3/6 | |
| 4/6 | |
| 5/6 | |
| 6/6 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/6] hw/mips/gt64xxx_pci: Fix endianness swap on big-endian hosts
While working on endianness consolidation I figured a long-standing bug in the GT64120 while accessing PCI config/data registers from the CPU bus (via the ISD).
While the debugging was painful, the fix is quite
easy: simply use the endianness MemoryRegionOps provided by the abstract PCI_HOST_BRIDGE class.
Patches 1-3 were useful while debugging. patch 5 is the fix and patch 6 add a test to keep testing on BE hosts.
Philippe Mathieu-Daudé (6):
hw/pci/pci_host: Trace config accesses on unexisting functions hw/mips/malta: Split FPGA LEDs/ASCII display updates hw/mips/malta: Trace FPGA LEDs/ASCII display updates hw/mips/gt64xxx_pci: Accumulate address space changes hw/mips/gt64xxx_pci: Endian-swap using PCI_HOST_BRIDGE MemoryRegionOps tests/avocado: Add tests booting YAMON ROM on MIPS Malta machines
hw/mips/gt64xxx_pci.c | 78 +++++++++++++++++++++-------- hw/mips/malta.c | 16 ++++-- hw/mips/trace-events | 4 ++ hw/pci/pci_host.c | 6 +++ tests/avocado/machine_mips_malta.py | 52 +++++++++++++++++-- 5 files changed, 127 insertions(+), 29 deletions(-)
Signature · 1 line
2.38.1