Skip to content

tty/serial: bool conversions and cleanups

Ilpo Järvinen linux-arm-kernel linux-bluetooth linux-mmc linux-s390 linux-serial linux-staging linux-usb linuxppc-dev lkml netdev sparclinux 4 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest12 patches 0 repliesNew
  2. v313 patches 9 repliesSuperseded
  3. v213 patches 5 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v110 patches18 repliesSuperseded

Changes in v4 from the cover letter

- Removed most of the USB serial changes from this series

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12tty: Cleanup tty_port_set_initialized() bool parameterdrivers/char/pcmcia/synclink_cs.c drivers/ipack/devices/ipoctal.c drivers/s390/char/con3215.c +8 more+20 -200 replies
2/12tty: Cleamup tty_port_set_suspended() bool parameterdrivers/tty/serial/serial_core.c+4 -40 replies
3/12tty: Cleanup tty_port_set_active() bool parameterdrivers/tty/amiserial.c drivers/tty/serial/serial_core.c drivers/tty/synclink_gt.c +1 more+11 -110 replies
4/12tty: moxa: Make local var storing tty_port_initialized() booldrivers/tty/moxa.c+1 -10 replies
5/12serial: Convert uart_{,port_}startup() init_hw param to booldrivers/tty/serial/serial_core.c+5 -50 replies
6/12tty: Convert ->carrier_raised() and callchains to booldrivers/char/pcmcia/synclink_cs.c drivers/mmc/core/sdio_uart.c drivers/tty/amiserial.c +9 more+32 -340 replies
7/12tty: Convert ->dtr_rts() to take bool argumentdrivers/char/pcmcia/synclink_cs.c drivers/mmc/core/sdio_uart.c drivers/staging/greybus/uart.c +13 more+52 -500 replies
8/12tty/serial: Make ->dcd_change()+uart_handle_dcd_change() status bool activedrivers/pps/clients/pps-ldisc.c drivers/tty/serial/serial_core.c drivers/tty/serial/sunhv.c +2 more+14 -150 replies
9/12serial: Make uart_handle_cts_change() status param bool activedrivers/tty/serial/imx.c drivers/tty/serial/max3100.c drivers/tty/serial/max310x.c +2 more+8 -100 replies
10/12tty: Return bool from tty_termios_hw_change()drivers/tty/tty_ioctl.c include/linux/tty.h+5 -50 replies
11/12tty: Call ->dtr_rts() parameter active consistentlydrivers/char/pcmcia/synclink_cs.c drivers/mmc/core/sdio_uart.c drivers/staging/greybus/uart.c +9 more+28 -280 replies
12/12tty: moxa: Rename dtr/rts parameters/variables to activedrivers/tty/moxa.c+26 -260 replies

Reviews trailers per patch

All 12 patches have a Reviewed-by or Acked-by.

PatchJiri SlabyUlf HanssonSamuel Iglesias GonsalvezJohan HovoldRodolfo Giometti
1/12R-b R-b
2/12R-b
3/12R-b
4/12R-b
5/12R-b
6/12R-b A-b
7/12R-b A-b
8/12R-b A-b
9/12R-b
10/12R-b R-b
11/12R-b A-b
12/12R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v4 thread

Cover letter [PATCH v4 00/12] tty/serial: bool conversions and cleanups

There are number of functions in tty/serial which have arguments or return types that expect/behave like bool. Likely due to them existing before bool was available, other types are used. Make conversions to bool and cleanups.

v4:
- Removed most of the USB serial changes from this series

v3:
- moxa: Fix function signature in comment
- moxa: Rearrange comment (0: off, 1: on) removal from rename change to bool change (effect is internal to the series)

v2:
- Call dtr/rts parameters/variables consistently "active"
- Don't chain one return statement with ||
- Don't change function signatures to >80 chars ("while at it")
- moxa: differentiated dtr and status variables

Ilpo Järvinen (12):
tty: Cleanup tty_port_set_initialized() bool parameter
tty: Cleamup tty_port_set_suspended() bool parameter
tty: Cleanup tty_port_set_active() bool parameter
tty: moxa: Make local var storing tty_port_initialized() bool
serial: Convert uart_{,port_}startup() init_hw param to bool
tty: Convert ->carrier_raised() and callchains to bool
tty: Convert ->dtr_rts() to take bool argument tty/serial: Make ->dcd_change()+uart_handle_dcd_change() status bool
active
serial: Make uart_handle_cts_change() status param bool active
tty: Return bool from tty_termios_hw_change()
tty: Call ->dtr_rts() parameter active consistently
tty: moxa: Rename dtr/rts parameters/variables to active

 drivers/char/pcmcia/synclink_cs.c | 18 +++----
 drivers/ipack/devices/ipoctal.c   |  4 +-
 drivers/mmc/core/sdio_uart.c      | 13 +++--
 drivers/pps/clients/pps-ldisc.c   |  6 +--
 drivers/s390/char/con3215.c       |  4 +-
 drivers/staging/greybus/uart.c    |  4 +-
 drivers/tty/amiserial.c           | 12 ++---
 drivers/tty/hvc/hvc_console.c     |  4 +-
 drivers/tty/hvc/hvc_console.h     |  2 +-
 drivers/tty/hvc/hvc_iucv.c        |  6 +--
 drivers/tty/moxa.c                | 82 ++++++++++++++++---------------
 drivers/tty/mxser.c               | 11 +++--
 drivers/tty/n_gsm.c               | 16 +++---
 drivers/tty/serial/imx.c          |  2 +-
 drivers/tty/serial/max3100.c      |  2 +-
 drivers/tty/serial/max310x.c      |  3 +-
 drivers/tty/serial/serial_core.c  | 65 ++++++++++++------------
 drivers/tty/serial/sunhv.c        |  8 +--
 drivers/tty/synclink_gt.c         | 21 ++++----
 drivers/tty/tty_ioctl.c           |  8 +--
 drivers/tty/tty_port.c            | 22 ++++-----
 drivers/usb/class/cdc-acm.c       |  4 +-
 drivers/usb/serial/console.c      |  2 +-
 drivers/usb/serial/usb-serial.c   |  6 +--
 include/linux/serial_core.h       |  6 +--
 include/linux/tty.h               |  2 +-
 include/linux/tty_ldisc.h         |  4 +-
 include/linux/tty_port.h          | 10 ++--
 net/bluetooth/rfcomm/tty.c        |  2 +-
 29 files changed, 173 insertions(+), 176 deletions(-)
Signature · 1 line
2.30.2