tty/serial: bool conversions and cleanups
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest12 patches 0 repliesNew
- v313 patches 9 repliesSuperseded
- v213 patches 5 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 10 patches | 18 replies | Superseded |
Changes in v4 from the cover letter
- Removed most of the USB serial changes from this series
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/12 | tty: Cleanup tty_port_set_initialized() bool parameterdrivers/ drivers/ drivers/ +8 more | +20 | 0 replies | |
| 2/12 | tty: Cleamup tty_port_set_suspended() bool parameterdrivers/ | +4 | 0 replies | |
| 3/12 | tty: Cleanup tty_port_set_active() bool parameterdrivers/ drivers/ drivers/ +1 more | +11 | 0 replies | |
| 4/12 | tty: moxa: Make local var storing tty_port_initialized() booldrivers/ | +1 | 0 replies | |
| 5/12 | serial: Convert uart_{,port_}startup() init_hw param to booldrivers/ | +5 | 0 replies | |
| 6/12 | tty: Convert ->carrier_raised() and callchains to booldrivers/ drivers/ drivers/ +9 more | +32 | 0 replies | |
| 7/12 | tty: Convert ->dtr_rts() to take bool argumentdrivers/ drivers/ drivers/ +13 more | +52 | 0 replies | |
| 8/12 | tty/serial: Make ->dcd_change()+uart_handle_dcd_change() status bool activedrivers/ drivers/ drivers/ +2 more | +14 | 0 replies | |
| 9/12 | serial: Make uart_handle_cts_change() status param bool activedrivers/ drivers/ drivers/ +2 more | +8 | 0 replies | |
| 10/12 | tty: Return bool from tty_termios_hw_change()drivers/ include/ | +5 | 0 replies | |
| 11/12 | tty: Call ->dtr_rts() parameter active consistentlydrivers/ drivers/ drivers/ +9 more | +28 | 0 replies | |
| 12/12 | tty: moxa: Rename dtr/rts parameters/variables to activedrivers/ | +26 | 0 replies |
Reviews trailers per patch
All 12 patches have a Reviewed-by or Acked-by.
| Patch | Jiri Slaby | Ulf Hansson | Samuel Iglesias Gonsalvez | Johan Hovold | Rodolfo Giometti |
|---|---|---|---|---|---|
| 1/12 | R-b | R-b | |||
| 2/12 | R-b | ||||
| 3/12 | R-b | ||||
| 4/12 | R-b | ||||
| 5/12 | R-b | ||||
| 6/12 | R-b | A-b | |||
| 7/12 | R-b | A-b | |||
| 8/12 | R-b | A-b | |||
| 9/12 | R-b | ||||
| 10/12 | R-b | R-b | |||
| 11/12 | R-b | A-b | |||
| 12/12 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.
Cover letter [PATCH v4 00/12] tty/serial: bool conversions and cleanups
There are number of functions in tty/serial which have arguments or return types that expect/behave like bool. Likely due to them existing before bool was available, other types are used. Make conversions to bool and cleanups.
v4:
- Removed most of the USB serial changes from this series
v3:
- moxa: Fix function signature in comment
- moxa: Rearrange comment (0: off, 1: on) removal from rename change to bool change (effect is internal to the series)
v2:
- Call dtr/rts parameters/variables consistently "active"
- Don't chain one return statement with ||
- Don't change function signatures to >80 chars ("while at it")
- moxa: differentiated dtr and status variables
Ilpo Järvinen (12):
tty: Cleanup tty_port_set_initialized() bool parameter
tty: Cleamup tty_port_set_suspended() bool parameter
tty: Cleanup tty_port_set_active() bool parameter
tty: moxa: Make local var storing tty_port_initialized() bool
serial: Convert uart_{,port_}startup() init_hw param to bool
tty: Convert ->carrier_raised() and callchains to bool
tty: Convert ->dtr_rts() to take bool argument tty/serial: Make ->dcd_change()+uart_handle_dcd_change() status bool
active
serial: Make uart_handle_cts_change() status param bool active
tty: Return bool from tty_termios_hw_change()
tty: Call ->dtr_rts() parameter active consistently
tty: moxa: Rename dtr/rts parameters/variables to active
drivers/char/pcmcia/synclink_cs.c | 18 +++---- drivers/ipack/devices/ipoctal.c | 4 +- drivers/mmc/core/sdio_uart.c | 13 +++-- drivers/pps/clients/pps-ldisc.c | 6 +-- drivers/s390/char/con3215.c | 4 +- drivers/staging/greybus/uart.c | 4 +- drivers/tty/amiserial.c | 12 ++--- drivers/tty/hvc/hvc_console.c | 4 +- drivers/tty/hvc/hvc_console.h | 2 +- drivers/tty/hvc/hvc_iucv.c | 6 +-- drivers/tty/moxa.c | 82 ++++++++++++++++--------------- drivers/tty/mxser.c | 11 +++-- drivers/tty/n_gsm.c | 16 +++--- drivers/tty/serial/imx.c | 2 +- drivers/tty/serial/max3100.c | 2 +- drivers/tty/serial/max310x.c | 3 +- drivers/tty/serial/serial_core.c | 65 ++++++++++++------------ drivers/tty/serial/sunhv.c | 8 +-- drivers/tty/synclink_gt.c | 21 ++++---- drivers/tty/tty_ioctl.c | 8 +-- drivers/tty/tty_port.c | 22 ++++----- drivers/usb/class/cdc-acm.c | 4 +- drivers/usb/serial/console.c | 2 +- drivers/usb/serial/usb-serial.c | 6 +-- include/linux/serial_core.h | 6 +-- include/linux/tty.h | 2 +- include/linux/tty_ldisc.h | 4 +- include/linux/tty_port.h | 10 ++-- net/bluetooth/rfcomm/tty.c | 2 +- 29 files changed, 173 insertions(+), 176 deletions(-)
Signature · 1 line
2.30.2