Skip to content

Don't allow REQ_NOWAIT for bio splitting

Jens Axboe linux-block stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2block: handle bio_split_to_limits() NULL returnblock/blk-merge.c block/blk-mq.c drivers/block/drbd/drbd_req.c +5 more+19 -23 replies
2/2block: don't allow splitting of a REQ_NOWAIT bioblock/blk-merge.c+10 -04 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchKeith Busch
1/2
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] Don't allow REQ_NOWAIT for bio splitting

Hi,

If we end up needing to split a bio that is marked with REQ_NOWAIT, it's entirely possible that any part of the split bio will hit a failure trying to get submitted. If this happens, then the entire request ends up being errored with BLK_STS_AGAIN, even if any parts of this bio has been read or written to the device/file.

Rather than end up in this odd state, disallow splitting with REQ_NOWAIT. If we end the entire request upfront with EAGAIN, then we don't end up with a partially written IO that still returns EAGAIN.

Signature · 1 line
Jens Axboe