Skip to content

net/slirp: Add mfr-id and oob-eth-addr parameters

Peter Delevoryas qemu-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 patch 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1net/slirp: Add mfr-id and oob-eth-addr parametersnet/slirp.c qapi/net.json+24 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/1] net/slirp: Add mfr-id and oob-eth-addr parameters

This adds mfr-id and oob-eth-addr parameters to the userspace netdev backend.

    -netdev user,id=[str],mfr-id=[uint32],oob-eth-addr=[MAC address]

I introduced mfr-id and oob-eth-addr to slirp a while ago, as part of Slirp config version 5, but never managed to get the options exposed in upstream QEMU (I've just been maintaining my own patches).

This is useful for testing NC-SI OEM commands, which are critical for bringing up the network path for lots of BMC's in data centers. So like, OpenBMC devs would be interested in this.

I tried to submit this change a long time ago, but failed cause I wasn't sure exactly how to gate this on the slirp version.

My strategy was actually not to use the slirp version (e.g. 4.7.0) to check for this, but to use the slirp config version. This is different, but correct, I think? If we don't use the slirp config version, we have to create a new slirp release, 4.8.0. But, I don't see the point of that, because we already have a version number exposed for the SlirpConfig.

Thanks,
Peter

Peter Delevoryas (1):
net/slirp: Add mfr-id and oob-eth-addr parameters

 net/slirp.c   | 19 ++++++++++++++++---
 qapi/net.json |  9 ++++++++-
 2 files changed, 24 insertions(+), 4 deletions(-)
Signature · 1 line
2.31.1