Skip to content

kvm: x86/mmu: Share the same code to invalidate each vTLB entry

Lai Jiangshan kvm lkml 3 versions – Applied

Status from this message: Applied to kvm-x86 mmu, thanks! Made a few tweaks, I'll respond to invididual

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest14 patches 1 replyApplied
  2. v28 patches 6 repliesSuperseded
  3. v17 patches 8 repliesSuperseded

Changes in v3 from the cover letter

Convert the address type and fix subtle bug Check mmu->sync_page pointer before calling it Fix the defination of KVM_MMU_ROOT_XXX

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/14KVM: x86/mmu: Use 64-bit address to invalidate to fix a subtle bugarch/x86/include/asm/kvm_host.h arch/x86/kvm/mmu/mmu.c arch/x86/kvm/mmu/paging_tmpl.h +1 more+17 -160 replies
2/14kvm: x86/mmu: Move the check in FNAME(sync_page) as kvm_sync_page_check()arch/x86/kvm/mmu/mmu.c arch/x86/kvm/mmu/paging_tmpl.h+42 -280 replies
3/14kvm: x86/mmu: Check mmu->sync_page pointer in kvm_sync_page_check()arch/x86/kvm/mmu/mmu.c+1 -10 replies
4/14kvm: x86/mmu: Set mmu->sync_page as NULL for direct pagingarch/x86/kvm/mmu/mmu.c+2 -80 replies
5/14kvm: x86/mmu: Move the code out of FNAME(sync_page)'s loop body into mmu.carch/x86/include/asm/kvm_host.h arch/x86/kvm/mmu/mmu.c arch/x86/kvm/mmu/paging_tmpl.h+76 -760 replies
6/14kvm: x86/mmu: Reduce the update to the spte in FNAME(sync_spte)arch/x86/kvm/mmu/paging_tmpl.h+5 -00 replies
7/14KVM: x86/mmu: Sanity check input to kvm_mmu_free_roots()arch/x86/include/asm/kvm_host.h arch/x86/kvm/mmu/mmu.c+6 -40 replies
8/14kvm: x86/mmu: Use KVM_MMU_ROOT_XXX for kvm_mmu_invalidate_addr()arch/x86/include/asm/kvm_host.h arch/x86/kvm/mmu/mmu.c arch/x86/kvm/x86.c+22 -210 replies
9/14kvm: x86/mmu: Use kvm_mmu_invalidate_addr() in kvm_mmu_invpcid_gva()arch/x86/kvm/mmu/mmu.c+7 -140 replies
10/14kvm: x86/mmu: Use kvm_mmu_invalidate_addr() in nested_ept_invalidate_addr()arch/x86/kvm/mmu/mmu.c arch/x86/kvm/vmx/nested.c+5 -10 replies
11/14kvm: x86/mmu: Allow the roots to be invalid in FNAME(invlpg)arch/x86/kvm/mmu/mmu.c arch/x86/kvm/mmu/paging_tmpl.h+2 -50 replies
12/14kvm: x86/mmu: Remove FNAME(invlpg) and use FNAME(sync_spte) to update vTLB instead.arch/x86/include/asm/kvm_host.h arch/x86/kvm/mmu/mmu.c arch/x86/kvm/mmu/paging_tmpl.h+39 -750 replies
13/14kvm: x86/mmu: Remove @no_dirty_log from FNAME(prefetch_gpte)arch/x86/kvm/mmu/paging_tmpl.h+3 -40 replies
14/14kvm: x86/mmu: Skip calling mmu->sync_spte() when the spte is 0arch/x86/kvm/mmu/mmu.c arch/x86/kvm/mmu/paging_tmpl.h+3 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH V3 00/14] kvm: x86/mmu: Share the same code to invalidate each vTLB entry

From: Lai Jiangshan <[email protected]>

FNAME(invlpg) and FNAME(sync_page) invalidate vTLB entries but in slightly different methods.

Make them use the same method and share the same code.

Patch 1: Address a subtle bug reported by Sean Christopherson.
Patch 2-6: Add FNAME(sync_page)
Patch 7-14: Refactor code which uses FNAME(invlpg) and finally use FNAME(sync_page).

Changed from V2:
Convert the address type and fix subtle bug Check mmu->sync_page pointer before calling it Fix the defination of KVM_MMU_ROOT_XXX

[V2]: https://lore.kernel.org/lkml/[email protected]/
[V1]: https://lore.kernel.org/lkml/[email protected]/

Lai Jiangshan (13):
KVM: x86/mmu: Use 64-bit address to invalidate to fix a subtle bug
kvm: x86/mmu: Move the check in FNAME(sync_page) as
kvm_sync_page_check()
kvm: x86/mmu: Check mmu->sync_page pointer in kvm_sync_page_check()
kvm: x86/mmu: Set mmu->sync_page as NULL for direct paging
kvm: x86/mmu: Move the code out of FNAME(sync_page)'s loop body into
mmu.c
kvm: x86/mmu: Reduce the update to the spte in FNAME(sync_spte)
kvm: x86/mmu: Use KVM_MMU_ROOT_XXX for kvm_mmu_invalidate_addr()
kvm: x86/mmu: Use kvm_mmu_invalidate_addr() in kvm_mmu_invpcid_gva()
kvm: x86/mmu: Use kvm_mmu_invalidate_addr() in
nested_ept_invalidate_addr()
kvm: x86/mmu: Allow the roots to be invalid in FNAME(invlpg)
kvm: x86/mmu: Remove FNAME(invlpg) and use FNAME(sync_spte) to update
vTLB instead.
kvm: x86/mmu: Remove @no_dirty_log from FNAME(prefetch_gpte)
kvm: x86/mmu: Skip calling mmu->sync_spte() when the spte is 0

Sean Christopherson (1):
KVM: x86/mmu: Sanity check input to kvm_mmu_free_roots()

 arch/x86/include/asm/kvm_host.h |  17 ++-
 arch/x86/kvm/mmu/mmu.c          | 201 ++++++++++++++++++++----------
 arch/x86/kvm/mmu/paging_tmpl.h  | 209 +++++++++-----------------------
 arch/x86/kvm/vmx/nested.c       |   5 +-
 arch/x86/kvm/x86.c              |   4 +-
 5 files changed, 205 insertions(+), 231 deletions(-)
Signature · 1 line
2.19.1.6.gb485710b