devlink: remove the wait-for-references on unregister
Status from this message: This series was applied to netdev/net-next.git (master)
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 All 9 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | devlink: bump the instance index directly when iteratingnet/ net/ | +13 | 1 reply | Applied |
| 2/9 | devlink: update the code in netns move to latest helpersnet/ | +4 | 0 replies | Applied |
| 3/9 | devlink: protect devlink->dev by the instance locknet/ net/ net/ | +11 | 1 reply | Applied |
| 4/9 | devlink: always check if the devlink instance is registerednet/ net/ net/ +1 more | +60 | 4 replies | Applied |
| 5/9 | devlink: remove the registration guarantee of referencesinclude/ net/ net/ | +30 | 1 reply | Applied |
| 6/9 | devlink: don't require setting features before registrationnet/ | +0 | 1 reply | Applied |
| 7/9 | devlink: allow registering parameters after the instancenet/ | +11 | 22 replies | Applied |
| 8/9 | netdevsim: rename a labeldrivers/ | +2 | 1 reply | Applied |
| 9/9 | netdevsim: move devlink registration under the instance lockdrivers/ | +8 | 1 reply | Applied |
Reviews trailers per patch
All 9 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Jiri Pirko | Jacob Keller |
|---|---|---|
| Series | R-b | |
| 1/9 | R-b | |
| 2/9 | R-b | |
| 3/9 | R-b | |
| 4/9 | R-b | |
| 5/9 | R-b | R-b |
| 6/9 | R-b | |
| 7/9 | R-b | |
| 8/9 | R-b | R-b |
| 9/9 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH net-next 0/9] devlink: remove the wait-for-references on unregister
Move the registration and unregistration of the devlink instances under their instance locks. Don't perform the netdev-style wait for all references when unregistering the instance.
Instead the devlink instance refcount will only ensure that the memory of the instance is not freed. All places which acquire access to devlink instances via a reference must check that the instance is still registered under the instance lock.
This fixes the problem of the netdev code accessing devlink instances before they are registered.
RFC: https://lore.kernel.org/all/[email protected]/
- rewrite the cover letter
- rewrite the commit message for patch 1
- un-export and rename devl_is_alive
- squash the netdevsim patches
Jakub Kicinski (9):
devlink: bump the instance index directly when iterating
devlink: update the code in netns move to latest helpers
devlink: protect devlink->dev by the instance lock
devlink: always check if the devlink instance is registered
devlink: remove the registration guarantee of references
devlink: don't require setting features before registration
devlink: allow registering parameters after the instance
netdevsim: rename a label
netdevsim: move devlink registration under the instance lock
drivers/net/netdevsim/dev.c | 15 +++-- include/net/devlink.h | 2 + net/devlink/core.c | 121 ++++++++++++++++-------------------- net/devlink/devl_internal.h | 28 ++++----- net/devlink/leftover.c | 64 ++++++++++++------- net/devlink/netlink.c | 19 ++++-- 6 files changed, 137 insertions(+), 112 deletions(-)
Signature · 1 line
2.38.1