RFC SBI system suspend (SUSP) extension
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest11 patches 0 repliesNew
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/11 | lib: sbi_hsm: Factor out invalid state detectionlib/ | +24 | 1 reply | |
| 2/11 | lib: sbi_hsm: Don't try to restore state on failed changelib/ | +2 | 1 reply | |
| 3/11 | lib: sbi_hsm: Ensure errors are consistent with speclib/ | +3 | 1 reply | |
| 4/11 | lib: sbi_hsm: Move misplaced commentlib/ | +4 | 1 reply | |
| 5/11 | lib: sbi_hsm: Remove unnecessary includelib/ | +2 | 1 reply | |
| 6/11 | lib: sbi_hsm: Export some functionsinclude/ lib/ | +14 | 1 reply | |
| 7/11 | lib: sbi: Add system suspend skeletoninclude/ include/ lib/ +3 more | +106 | 1 reply | |
| 8/11 | lib: sbi: Add system_suspend_allowed domain propertydocs/ include/ lib/ +1 more | +18 | 1 reply | |
| 9/11 | lib: sbi: Implement system suspendlib/ | +56 | 1 reply | |
| 10/11 | docs: Correct opensbi-domain property namedocs/ | +3 | 1 reply | |
| 11/11 | platform: generic: Add system suspend testdocs/ include/ lib/ +1 more | +54 | 1 reply |
Reviews trailers per patch
All 11 patches have a Reviewed-by or Acked-by.
| Patch | Anup Patel |
|---|---|
| 1/11 | R-b |
| 2/11 | R-b |
| 3/11 | R-b |
| 4/11 | R-b |
| 5/11 | R-b |
| 6/11 | R-b |
| 7/11 | R-b |
| 8/11 | R-b |
| 9/11 | R-b |
| 10/11 | R-b |
| 11/11 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [RFC PATCH 00/11] SBI system suspend (SUSP) extension
This series implements the SBI system suspend support in OpenSBI as-per the draft proposal for SBI system suspend which can be found at
https://github.com/jones-drew/riscv-sbi-doc/commit/d9e43e9a938fc3eb510e023c3f352462876f7785
The first half of the series are a few cleanups and fixes for HSM, as system suspend makes use of some of its code and patterns. The second half implements support for the extension and includes a patch which allows testing to be enabled, even when low-level firmware does not provide support. Regarding the test mode, it's currently enabled by adding a 'system-suspend-test' DT property, but Anup has suggested that FW_OPTION could also be used. I'm all ears for what people think the best way to control test functionality in OpenSBI is and am happy to switch it. To test with Linux the kernel must include the patch at
https://github.com/jones-drew/linux/commits/riscv/sbi-susp-rfc and be built with CONFIG_SUSPEND enabled.
The patches are based on v1.2 and "treewide: Replace TRUE/FALSE with true/false" and can also be found at
https://github.com/jones-drew/opensbi/commits/susp-rfc
Andrew Jones (11):
lib: sbi_hsm: Factor out invalid state detection
lib: sbi_hsm: Don't try to restore state on failed change
lib: sbi_hsm: Ensure errors are consistent with spec
lib: sbi_hsm: Move misplaced comment
lib: sbi_hsm: Remove unnecessary include
lib: sbi_hsm: Export some functions
lib: sbi: Add system suspend skeleton
lib: sbi: Add system_suspend_allowed domain property
lib: sbi: Implement system suspend
docs: Correct opensbi-domain property name
platform: generic: Add system suspend test
docs/domain_support.md | 15 +++- include/sbi/sbi_domain.h | 2 + include/sbi/sbi_ecall_interface.h | 8 +++ include/sbi/sbi_hsm.h | 4 ++ include/sbi/sbi_system.h | 18 +++++ lib/sbi/Kconfig | 4 ++ lib/sbi/objects.mk | 3 + lib/sbi/sbi_domain.c | 4 ++ lib/sbi/sbi_ecall_hsm.c | 4 +- lib/sbi/sbi_ecall_susp.c | 48 +++++++++++++ lib/sbi/sbi_hsm.c | 92 +++++++++++-------------- lib/sbi/sbi_system.c | 111 ++++++++++++++++++++++++++++++ lib/utils/fdt/fdt_domain.c | 7 ++ platform/generic/platform.c | 20 +++++- 14 files changed, 283 insertions(+), 57 deletions(-) create mode 100644 lib/sbi/sbi_ecall_susp.c
Signature · 1 line
2.39.0