Skip to content

Series of fixes for PL011 char device

Evgeny Iakovlev qemu-arm qemu-devel 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest5 patches 2 repliesIn review
  2. v35 patches 16 repliesSuperseded
  3. v24 patches 9 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches5 repliesSuperseded

Changes in v4 from the cover letter

* Fixed post_load hook to be backwards-migratable
* Refactored some code in 5/5 as per review comments

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5hw/char/pl011: refactor FIFO depth handling codehw/char/pl011.c include/hw/char/pl011.h+22 -130 replies
2/5hw/char/pl011: add post_load hook for backwards-compatibilityhw/char/pl011.c+25 -00 replies
3/5hw/char/pl011: implement a reset methodhw/char/pl011.c+21 -50 replies
4/5hw/char/pl011: better handling of FIFO flags on LCR resethw/char/pl011.c+13 -50 replies
5/5hw/char/pl011: check if UART is enabled before RX or TX operationhw/char/pl011.c+31 -50 replies

Reviews trailers per patch

4 of 5 patches have a Reviewed-by or Acked-by.

PatchPeter MaydellPhilippe Mathieu-Daudé
1/5R-b R-b
2/5
3/5R-b R-b
4/5R-b
5/5R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/5] Series of fixes for PL011 char device

v4:
* Fixed post_load hook to be backwards-migratable
* Refactored some code in 5/5 as per review comments

v3:
* Introduced a post_load hook for PL011State migration for backwards-compatibility due to some input state fragility.
* No longer touching irq lines in reset method
* Minor changes based on review feedback.

v2:
* Moved FIFO depth refactoring part of FIFO flags change into its own commit.
* Added a reset method for PL011

Evgeny Iakovlev (5):
hw/char/pl011: refactor FIFO depth handling code hw/char/pl011: add post_load hook for backwards-compatibility hw/char/pl011: implement a reset method
hw/char/pl011: better handling of FIFO flags on LCR reset hw/char/pl011: check if UART is enabled before RX or TX operation

 hw/char/pl011.c         | 121 +++++++++++++++++++++++++++++++++-------
 include/hw/char/pl011.h |   5 +-
 2 files changed, 105 insertions(+), 21 deletions(-)
Signature · 1 line
2.34.1